From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Colin Ian King <colin.i.king@gmail.com>,
James Smart <james.smart@broadcom.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
Date: Fri, 8 Mar 2024 00:12:52 +0000 [thread overview]
Message-ID: <8f4ec68d-ab2a-462d-8a65-d63931a12696@nvidia.com> (raw)
In-Reply-To: <20240307110158.1981401-1-colin.i.king@gmail.com>
On 3/7/24 03:01, Colin Ian King wrote:
> The inlined helper functions nvmet_fc_iodnum and nvmet_fc_fodnum are
> not used and are redundant. They have been in the code since 2016 and
> never been referenced. Remove them.
>
> Cleans up clang scan warnings such as:
> drivers/nvme/target/fc.c:177:1: warning: unused function
> 'nvmet_fc_iodnum' [-Wunused-function]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2024-03-08 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:01 Colin Ian King
2024-03-07 11:26 ` Sagi Grimberg
2024-03-08 0:12 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f4ec68d-ab2a-462d-8a65-d63931a12696@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=colin.i.king@gmail.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®