* [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
@ 2024-03-07 11:01 Colin Ian King
2024-03-07 11:26 ` Sagi Grimberg
2024-03-08 0:12 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-03-07 11:01 UTC (permalink / raw)
To: James Smart, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme
Cc: kernel-janitors, linux-kernel
The inlined helper functions nvmet_fc_iodnum and nvmet_fc_fodnum are
not used and are redundant. They have been in the code since 2016 and
never been referenced. Remove them.
Cleans up clang scan warnings such as:
drivers/nvme/target/fc.c:177:1: warning: unused function
'nvmet_fc_iodnum' [-Wunused-function]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/nvme/target/fc.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index fd229f310c93..a19fa50c840b 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc {
struct work_struct del_work;
};
-
-static inline int
-nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
-{
- return (iodptr - iodptr->tgtport->iod);
-}
-
-static inline int
-nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
-{
- return (fodptr - fodptr->queue->fod);
-}
-
-
/*
* Association and Connection IDs:
*
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
2024-03-07 11:01 [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum Colin Ian King
@ 2024-03-07 11:26 ` Sagi Grimberg
2024-03-08 0:12 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2024-03-07 11:26 UTC (permalink / raw)
To: Colin Ian King, James Smart, Christoph Hellwig,
Chaitanya Kulkarni, linux-nvme
Cc: kernel-janitors, linux-kernel
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
2024-03-07 11:01 [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum Colin Ian King
2024-03-07 11:26 ` Sagi Grimberg
@ 2024-03-08 0:12 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-03-08 0:12 UTC (permalink / raw)
To: Colin Ian King, James Smart, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme
Cc: kernel-janitors, linux-kernel
On 3/7/24 03:01, Colin Ian King wrote:
> The inlined helper functions nvmet_fc_iodnum and nvmet_fc_fodnum are
> not used and are redundant. They have been in the code since 2016 and
> never been referenced. Remove them.
>
> Cleans up clang scan warnings such as:
> drivers/nvme/target/fc.c:177:1: warning: unused function
> 'nvmet_fc_iodnum' [-Wunused-function]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-08 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 11:01 [PATCH][next] nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum Colin Ian King
2024-03-07 11:26 ` Sagi Grimberg
2024-03-08 0:12 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®