[PATCH v2] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[PATCH v2] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[Donjuanplatinum]

Add support for the MECHREVO WUJIE Series 15 X Pro (WUJIE
Series-X5SP4NAG).

I have tested the Uniwill features on my laptop: the RGB keyboard
backlight works correctly and supports a maximum brightness level of 4.
The secondary fan only starts when the system load and performance
level increase. AC auto boot and USB powershare also work correctly.
The Super key and CPU temperature reporting work correctly, with
temperatures reported in millidegrees Celsius.

This machine does not have an NVIDIA GPU; it uses an AMD GPU.

* drivers/platform/x86/uniwill/uniwill-acpi.c: Add
series_x5sp4nag_descriptor and DMI matching.

Signed-off-by: Yifei Yao <donplat@barrensea.org>
---
 drivers/platform/x86/uniwill/uniwill-acpi.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index 7a2eeaec4c96..d0fde42c46d7 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -2712,6 +2712,19 @@ static struct uniwill_device_descriptor lapkc71f_descriptor __initdata = {
 	.lightbar_max_brightness = 200,
 };
 
+static struct uniwill_device_descriptor series_x5sp4nag_descriptor __initdata = {
+	.features = UNIWILL_FEATURE_FN_LOCK |
+		    UNIWILL_FEATURE_SUPER_KEY |
+		    UNIWILL_FEATURE_CPU_TEMP |
+		    UNIWILL_FEATURE_PRIMARY_FAN |
+		    UNIWILL_FEATURE_SECONDARY_FAN |
+		    UNIWILL_FEATURE_KEYBOARD_BACKLIGHT |
+		    UNIWILL_FEATURE_AC_AUTO_BOOT |
+		    UNIWILL_FEATURE_USB_POWERSHARE,
+	.kbd_led_single_color = false,
+	.kbd_led_max_brightness = 4,
+};
+
 /*
  * The featuresets below reflect somewhat chronological changes:
  * 1 -> 2: UNIWILL_FEATURE_NVIDIA_CTGP_CONTROL is added to the EC firmware.
@@ -2996,6 +3009,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
 		},
 		.driver_data = &tux_featureset_4_descriptor,
 	},
+	{
+		.ident = "MECHREVO WUJIE Series 15 X Pro",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
+		},
+		.driver_data = &series_x5sp4nag_descriptor,
+	},
 	{
 		.ident = "TUXEDO InfinityBook Pro 14/15 Gen9 Intel/Commodore Omnia-Book 15 Gen9",
 		.matches = {
-- 
2.55.0

Re: [PATCH v2] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[Armin Wolf]

Am 11.10.26 um 10:14 schrieb Donjuanplatinum:

> Add support for the MECHREVO WUJIE Series 15 X Pro (WUJIE
> Series-X5SP4NAG).
>
> I have tested the Uniwill features on my laptop: the RGB keyboard
> backlight works correctly and supports a maximum brightness level of 4.
> The secondary fan only starts when the system load and performance
> level increase. AC auto boot and USB powershare also work correctly.
> The Super key and CPU temperature reporting work correctly, with
> temperatures reported in millidegrees Celsius.
>
> This machine does not have an NVIDIA GPU; it uses an AMD GPU.
>
> * drivers/platform/x86/uniwill/uniwill-acpi.c: Add
> series_x5sp4nag_descriptor and DMI matching.

Hi,

please remove this pointless block of text.

>
> Signed-off-by: Yifei Yao <donplat@barrensea.org>
> ---
>   drivers/platform/x86/uniwill/uniwill-acpi.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
> index 7a2eeaec4c96..d0fde42c46d7 100644
> --- a/drivers/platform/x86/uniwill/uniwill-acpi.c
> +++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
> @@ -2712,6 +2712,19 @@ static struct uniwill_device_descriptor lapkc71f_descriptor __initdata = {
>   	.lightbar_max_brightness = 200,
>   };
>   
> +static struct uniwill_device_descriptor series_x5sp4nag_descriptor __initdata = {
> +	.features = UNIWILL_FEATURE_FN_LOCK |
> +		    UNIWILL_FEATURE_SUPER_KEY |
> +		    UNIWILL_FEATURE_CPU_TEMP |
> +		    UNIWILL_FEATURE_PRIMARY_FAN |
> +		    UNIWILL_FEATURE_SECONDARY_FAN |
> +		    UNIWILL_FEATURE_KEYBOARD_BACKLIGHT |
> +		    UNIWILL_FEATURE_AC_AUTO_BOOT |
> +		    UNIWILL_FEATURE_USB_POWERSHARE,
> +	.kbd_led_single_color = false,
> +	.kbd_led_max_brightness = 4,
> +};

Can you check if UNIWILL_FEATURE_BATTERY_CHARGE_MODES also works on your device?
Please note that the embedded controller will still report to charge the battery
to 100%, so this is not a reliable indicator. Do you know if the Windows OEM app
provides such a setting on this device?

Thanks,
Armin Wolf

> +
>   /*
>    * The featuresets below reflect somewhat chronological changes:
>    * 1 -> 2: UNIWILL_FEATURE_NVIDIA_CTGP_CONTROL is added to the EC firmware.
> @@ -2996,6 +3009,14 @@ static const struct dmi_system_id uniwill_dmi_table[] __initconst = {
>   		},
>   		.driver_data = &tux_featureset_4_descriptor,
>   	},
> +	{
> +		.ident = "MECHREVO WUJIE Series 15 X Pro",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "WUJIE Series-X5SP4NAG"),
> +		},
> +		.driver_data = &series_x5sp4nag_descriptor,
> +	},
>   	{
>   		.ident = "TUXEDO InfinityBook Pro 14/15 Gen9 Intel/Commodore Omnia-Book 15 Gen9",
>   		.matches = {