From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Chukun Pan <amadeus@jmu.edu.cn>, Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi
Date: Sat, 30 Nov 2024 15:50:51 +0100 [thread overview]
Message-ID: <8f7c8c5d-6637-43b1-b8ba-1616e4db949f@oss.qualcomm.com> (raw)
In-Reply-To: <20241110140019.3426181-4-amadeus@jmu.edu.cn>
On 10.11.2024 3:00 PM, Chukun Pan wrote:
> Some IPQ60xx SoCs don't come with the mp5496 pmic chip. The mp5496
> pmic was never part of the IPQ60xx SoC, it's optional, so we moved
> it out of the soc dtsi.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 2 +-
> arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi | 35 ++++++++++++++++++++
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 14 --------
> 3 files changed, 36 insertions(+), 15 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> index f5f4827c0e17..9c69d3027b43 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts
> @@ -7,7 +7,7 @@
>
> /dts-v1/;
>
> -#include "ipq6018.dtsi"
> +#include "ipq6018-mp5496.dtsi"
>
> / {
> model = "Qualcomm Technologies, Inc. IPQ6018/AP-CP01-C1";
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> new file mode 100644
> index 000000000000..fe2152df69f4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq6018-mp5496.dtsi
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * ipq6018-mp5496.dtsi describes common properties (e.g. regulators) that
> + * apply to most devices that make use of the IPQ6018 SoC and MP5496 PMIC.
> + */
It's good to retain the copyright notices if you extract data out a file
lgtm otherwise
Konrad
next prev parent reply other threads:[~2024-11-30 14:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 14:00 [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
2024-11-10 14:00 ` [PATCH v4 1/4] arm64: dts: qcom: ipq6018: add 1.2GHz " Chukun Pan
2024-11-30 14:47 ` Konrad Dybcio
2024-12-22 5:20 ` Chukun Pan
2024-12-23 10:58 ` Konrad Dybcio
2024-12-24 7:00 ` Chukun Pan
2024-12-30 14:15 ` Konrad Dybcio
2025-01-03 3:00 ` Chukun Pan
2025-01-03 11:52 ` Konrad Dybcio
2024-11-10 14:00 ` [PATCH v4 2/4] arm64: dts: qcom: ipq6018: add 1.5GHz " Chukun Pan
2024-11-30 14:48 ` Konrad Dybcio
2024-11-10 14:00 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
2024-11-30 14:50 ` Konrad Dybcio [this message]
2024-11-10 14:00 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
2024-11-30 14:51 ` Konrad Dybcio
2024-12-22 4:38 ` [PATCH 1/1] arm64: dts: rockchip: default to host mode for USB on Radxa E25 Chukun Pan
2024-12-22 4:40 ` [PATCH v4 4/4] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
2024-12-22 5:08 ` Dmitry Baryshkov
2024-11-10 15:30 ` [PATCH v4 0/4] arm64: dts: qcom: ipq6018: rework CPU Frequency Chukun Pan
2024-11-10 15:30 ` [PATCH v4 3/4] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi Chukun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f7c8c5d-6637-43b1-b8ba-1616e4db949f@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amadeus@jmu.edu.cn \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®