* [PATCH] power: supply: axp288_charger: Omit superfluous error message
@ 2020-04-15 4:27 Tang Bin
2020-04-15 8:07 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Tang Bin @ 2020-04-15 4:27 UTC (permalink / raw)
To: sre, wens, hdegoede; +Cc: linux-pm, linux-kernel, Tang Bin, Shengju Zhang
In the axp288_charger_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
---
drivers/power/supply/axp288_charger.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
index 1bbba6bba..16fb4ae1c 100644
--- a/drivers/power/supply/axp288_charger.c
+++ b/drivers/power/supply/axp288_charger.c
@@ -825,10 +825,9 @@ static int axp288_charger_probe(struct platform_device *pdev)
/* Register charger interrupts */
for (i = 0; i < CHRG_INTR_END; i++) {
pirq = platform_get_irq(info->pdev, i);
- if (pirq < 0) {
- dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq);
+ if (pirq < 0)
return pirq;
- }
+
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_warn(&info->pdev->dev,
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: axp288_charger: Omit superfluous error message
2020-04-15 4:27 [PATCH] power: supply: axp288_charger: Omit superfluous error message Tang Bin
@ 2020-04-15 8:07 ` Hans de Goede
2020-04-16 1:35 ` [PATCH] power: supply: axp288_charger: Omit superfluous errormessage Tang Bin
2020-04-28 23:49 ` [PATCH] power: supply: axp288_charger: Omit superfluous error message Sebastian Reichel
0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2020-04-15 8:07 UTC (permalink / raw)
To: Tang Bin, sre, wens; +Cc: linux-pm, linux-kernel, Shengju Zhang
Hi,
On 4/15/20 6:27 AM, Tang Bin wrote:
> In the axp288_charger_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant
> message here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Thank you for this nice cleanup patch:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/power/supply/axp288_charger.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
> index 1bbba6bba..16fb4ae1c 100644
> --- a/drivers/power/supply/axp288_charger.c
> +++ b/drivers/power/supply/axp288_charger.c
> @@ -825,10 +825,9 @@ static int axp288_charger_probe(struct platform_device *pdev)
> /* Register charger interrupts */
> for (i = 0; i < CHRG_INTR_END; i++) {
> pirq = platform_get_irq(info->pdev, i);
> - if (pirq < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq);
> + if (pirq < 0)
> return pirq;
> - }
> +
> info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
> if (info->irq[i] < 0) {
> dev_warn(&info->pdev->dev,
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: axp288_charger: Omit superfluous errormessage
2020-04-15 8:07 ` Hans de Goede
@ 2020-04-16 1:35 ` Tang Bin
2020-04-28 23:49 ` [PATCH] power: supply: axp288_charger: Omit superfluous error message Sebastian Reichel
1 sibling, 0 replies; 4+ messages in thread
From: Tang Bin @ 2020-04-16 1:35 UTC (permalink / raw)
To: Hans de Goede, sre, wens; +Cc: linux-pm, linux-kernel
Hi Hans:
On 2020/4/15 16:07, Hans de Goede wrote:
> Hi,
>
> On 4/15/20 6:27 AM, Tang Bin wrote:
>> In the axp288_charger_probe(), when get irq failed, the function
>> platform_get_irq() logs an error message, so remove redundant
>> message here.
>>
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
>
> Thank you for this nice cleanup patch:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
Thanks,
Tang Bin
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: axp288_charger: Omit superfluous error message
2020-04-15 8:07 ` Hans de Goede
2020-04-16 1:35 ` [PATCH] power: supply: axp288_charger: Omit superfluous errormessage Tang Bin
@ 2020-04-28 23:49 ` Sebastian Reichel
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2020-04-28 23:49 UTC (permalink / raw)
To: Hans de Goede; +Cc: Tang Bin, wens, linux-pm, linux-kernel, Shengju Zhang
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi,
On Wed, Apr 15, 2020 at 10:07:03AM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/15/20 6:27 AM, Tang Bin wrote:
> > In the axp288_charger_probe(), when get irq failed, the function
> > platform_get_irq() logs an error message, so remove redundant
> > message here.
> >
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
>
> Thank you for this nice cleanup patch:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 4:27 [PATCH] power: supply: axp288_charger: Omit superfluous error message Tang Bin
2020-04-15 8:07 ` Hans de Goede
2020-04-16 1:35 ` [PATCH] power: supply: axp288_charger: Omit superfluous errormessage Tang Bin
2020-04-28 23:49 ` [PATCH] power: supply: axp288_charger: Omit superfluous error message Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®