* [PATCH 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings
@ 2026-07-21 11:35 Abel Vesa
2026-07-21 11:35 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
2026-07-21 11:35 ` [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa
0 siblings, 2 replies; 6+ messages in thread
From: Abel Vesa @ 2026-07-21 11:35 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Luca Weiss,
Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa
It has been pointed out [1] that, since the ADSP found on Eliza is
compatible with the ones from SM8750 class, they should be documented
in the SM8550 schema.
So move the compatible from Milos schema to the SM8550 one and then add
the fallback compatible to the node in the Eliza SoC DTSI.
This will also now be in line with the SM8550 driver match data which is
tied to the Eliza ADSP compatible in the driver.
[1] https://lore.kernel.org/all/20260721-benevolent-wonderful-kakapo-ca8c2c@quoll/
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Abel Vesa (2):
dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema
arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc
Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 3 ---
Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 3 +++
arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 3fe08b9796f36ef437ab9328e7dd1e5ff2d66603
change-id: 20260721-dts-qcom-eliza-fix-adsp-binding-b7712a026b20
Best regards,
--
Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema 2026-07-21 11:35 [PATCH 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa @ 2026-07-21 11:35 ` Abel Vesa 2026-07-21 15:09 ` Krzysztof Kozlowski 2026-07-21 11:35 ` [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa 1 sibling, 1 reply; 6+ messages in thread From: Abel Vesa @ 2026-07-21 11:35 UTC (permalink / raw) To: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa The ADSP PAS found on Eliza SoC looks fully compatible with SM8750, which can fallback to SM8550 except for the extra interrupt ("shutdown-ack"). So document its bindings in the SM8550 schema instead. Fixes: 7cf2f07f949c ("dt-bindings: remoteproc: qcom,milos-pas: Document Eliza ADSP") Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com> --- Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 3 --- Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml index 99d7337e58ec..b24e6f6eaf37 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml @@ -16,7 +16,6 @@ description: properties: compatible: enum: - - qcom,eliza-adsp-pas - qcom,milos-adsp-pas - qcom,milos-cdsp-pas - qcom,milos-mpss-pas @@ -88,7 +87,6 @@ allOf: properties: compatible: enum: - - qcom,eliza-adsp-pas - qcom,milos-adsp-pas - qcom,milos-cdsp-pas then: @@ -109,7 +107,6 @@ allOf: compatible: contains: enum: - - qcom,eliza-adsp-pas - qcom,milos-adsp-pas then: properties: diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml index 2a4c527552e6..019db91be7fd 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml @@ -29,6 +29,7 @@ properties: - qcom,x1e80100-cdsp-pas - items: - enum: + - qcom,eliza-adsp-pas - qcom,glymur-adsp-pas - qcom,hawi-adsp-pas - qcom,kaanapali-adsp-pas @@ -134,6 +135,7 @@ allOf: compatible: contains: enum: + - qcom,eliza-adsp-pas - qcom,glymur-adsp-pas - qcom,glymur-cdsp-pas - qcom,hawi-adsp-pas @@ -232,6 +234,7 @@ allOf: compatible: contains: enum: + - qcom,eliza-adsp-pas - qcom,sm8550-adsp-pas - qcom,sm8650-adsp-pas - qcom,x1e80100-adsp-pas -- 2.54.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema 2026-07-21 11:35 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa @ 2026-07-21 15:09 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-07-21 15:09 UTC (permalink / raw) To: Abel Vesa, Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Konrad Dybcio On 21/07/2026 13:35, Abel Vesa wrote: > @@ -232,6 +234,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,eliza-adsp-pas > - qcom,sm8550-adsp-pas > - qcom,sm8650-adsp-pas > - qcom,x1e80100-adsp-pas > I think this hunk is not needed, because it is covered by fallback and contains. I made today same mistake :) Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc 2026-07-21 11:35 [PATCH 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa 2026-07-21 11:35 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa @ 2026-07-21 11:35 ` Abel Vesa 2026-07-21 13:41 ` Dmitry Baryshkov 2026-07-21 15:10 ` Krzysztof Kozlowski 1 sibling, 2 replies; 6+ messages in thread From: Abel Vesa @ 2026-07-21 11:35 UTC (permalink / raw) To: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa The ADSP found on Eliza SoC is actually fully compatible with the ones from SM8750 class. So add the SM8550 compatible as fallback, just like the rest from the SM8750 class SoCs. Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes") Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi index 357e8066c176..5712c094cbb3 100644 --- a/arch/arm64/boot/dts/qcom/eliza.dtsi +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi @@ -1967,7 +1967,7 @@ tcsr: clock-controller@1fbf000 { }; remoteproc_adsp: remoteproc@3000000 { - compatible = "qcom,eliza-adsp-pas"; + compatible = "qcom,eliza-adsp-pas", "qcom,sm8550-adsp-pas"; reg = <0x0 0x03000000 0x0 0x10000>; interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>, -- 2.54.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc 2026-07-21 11:35 ` [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa @ 2026-07-21 13:41 ` Dmitry Baryshkov 2026-07-21 15:10 ` Krzysztof Kozlowski 1 sibling, 0 replies; 6+ messages in thread From: Dmitry Baryshkov @ 2026-07-21 13:41 UTC (permalink / raw) To: Abel Vesa Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Konrad Dybcio, Krzysztof Kozlowski On Tue, Jul 21, 2026 at 02:35:08PM +0300, Abel Vesa wrote: > The ADSP found on Eliza SoC is actually fully compatible with the ones > from SM8750 class. So add the SM8550 compatible as fallback, just like > the rest from the SM8750 class SoCs. > > Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes") > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc 2026-07-21 11:35 ` [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa 2026-07-21 13:41 ` Dmitry Baryshkov @ 2026-07-21 15:10 ` Krzysztof Kozlowski 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2026-07-21 15:10 UTC (permalink / raw) To: Abel Vesa, Bjorn Andersson, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Konrad Dybcio On 21/07/2026 13:35, Abel Vesa wrote: > The ADSP found on Eliza SoC is actually fully compatible with the ones > from SM8750 class. So add the SM8550 compatible as fallback, just like > the rest from the SM8750 class SoCs. > > Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes") > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-21 15:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-07-21 11:35 [PATCH 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa 2026-07-21 11:35 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa 2026-07-21 15:09 ` Krzysztof Kozlowski 2026-07-21 11:35 ` [PATCH 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa 2026-07-21 13:41 ` Dmitry Baryshkov 2026-07-21 15:10 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®