mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <beanhuo@iokpp.de>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	asutoshd@codeaurora.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, stanley.chu@mediatek.com,
	beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org,
	daejun7.park@samsung.com, huobean@gmail.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement
Date: Tue, 18 Oct 2022 11:20:52 -0700	[thread overview]
Message-ID: <8fbe22f1-d216-3841-62c3-675dcb8b6e8d@acm.org> (raw)
In-Reply-To: <20221018181627.326657-2-beanhuo@iokpp.de>

On 10/18/22 11:16, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
> 
> LUs with WB potential support are properly checked in ufshcd_wb_probe()
> before calling ufshcd_read_unit_desc_param(), so remove this unnecessary
> if-checkup in ufs_is_valid_unit_desc_lun() to match its function definition.

Hi Bean,

Does this patch differ from a revert of Jaegeuk's patch? If not, please 
change the patch title into "Revert scsi: ufs: WB is only available on 
LUN #0 to #7" and add "Cc: Jaegeuk Kim <jaegeuk@kernel.org>" just above 
the Signed-off-by line.

Thanks,

Bart.


  reply	other threads:[~2022-10-18 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 18:16 [PATCH v3 0/3] Changes for ufshcd.c Bean Huo
2022-10-18 18:16 ` [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement Bean Huo
2022-10-18 18:20   ` Bart Van Assche [this message]
2022-10-18 18:23     ` Bean Huo
2022-10-18 18:16 ` [PATCH v3 2/3] scsi: ufs: core: Cleanup ufshcd_slave_alloc() Bean Huo
2022-10-18 18:27   ` Bart Van Assche
2022-10-22 21:30     ` Bean Huo
2022-10-18 18:16 ` [PATCH v3 3/3] scsi: ufs: core: Use is_visible to control UFS unit descriptor sysfs nodes Bean Huo
2022-10-18 18:23   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fbe22f1-d216-3841-62c3-675dcb8b6e8d@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@iokpp.de \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=daejun7.park@samsung.com \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®