mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Danish Khateeb <danishkhateeb03@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>, Shuah Khan <shuah@kernel.org>,
	 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] tools/nolibc: fix WIFSIGNALED() for status 0
Date: Thu, 24 Sep 2026 10:41:53 +0200	[thread overview]
Message-ID: <8fd097e6-ff23-41f6-ad3e-273e5e9b26f3@t-8ch.de> (raw)
In-Reply-To: <20260923205622.1123270-1-danishkhateeb03@gmail.com>

On 2026-09-23 15:56:20-0500, Danish Khateeb wrote:
> nolibc's WIFSIGNALED() is true for status 0, so a child that exits with
> 0 looks as if it was killed by signal 0. I ran into it in a nolibc init
> for a QEMU test, which reported every clean exit of a child that way.
> 
> Patch 1 fixes the macro. Patch 2 adds nolibc-test cases for the wait
> status macros, which would have caught it.
> 
> Tested on top of nolibc/for-next f2212892b6a0:
> - x86_64: without patch 1, the new wifsignaled_exit0 test fails, and
>   the rest of nolibc-test gives the same results with and without it.
> - x86_64, i386, and arm and sparc64 under qemu-user: all new tests pass.
> - libc-test against glibc: all new tests pass, so the expected values
>   match glibc.
> 
> Danish Khateeb (2):
>   tools/nolibc: fix WIFSIGNALED() for status 0
>   selftests/nolibc: add tests for the wait status macros

Applied without the Cc stable, as we don't do that in the nolibc
subsystem.

Thanks!

>  tools/include/nolibc/types.h                 | 2 +-
>  tools/testing/selftests/nolibc/nolibc-test.c | 8 ++++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> 
> base-commit: f2212892b6a0c2adab438783e9fa8093c90786d7
> -- 
> 2.55.0
> 

      parent reply	other threads:[~2026-09-24  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 20:56 Danish Khateeb
2026-09-23 20:56 ` [PATCH 1/2] " Danish Khateeb
2026-09-23 20:56 ` [PATCH 2/2] selftests/nolibc: add tests for the wait status macros Danish Khateeb
2026-09-24  8:41 ` Thomas Weißschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fd097e6-ff23-41f6-ad3e-273e5e9b26f3@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=danishkhateeb03@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®