mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Sasha Levin <sashal@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
	lkft-triage@lists.linaro.org, pavel@nabladev.com,
	f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, rwarsow@gmx.de,
	conor@kernel.org, hargar@microsoft.com, broonie@kernel.org,
	achill@achill.org, sr@sladewatkins.com,
	linux-tegra@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6.1 0000/1879] 6.1.191-rc2 review
Date: Mon, 2 Nov 2026 14:34:59 +0000	[thread overview]
Message-ID: <8fd15777-fc45-4293-8255-c8d3d28a8156@nvidia.com> (raw)
In-Reply-To: <2026-11-01-1-daily-reply-0001-stmmac-tegra-6-1@kernel.org>


On 01/11/2026 14:43, Sasha Levin wrote:
>> Bisecting is pointing to the below commit and reverting it fixes
>> the above issues ...
>>
>> # first bad commit: [26c5e136ba4e94ad708333c9bd34039a1de397b0] net: stmmac: protect updates of 64-bit statistics counters
> 
> Thanks for bisecting. 6.1 is missing a prerequisite for that backport.
> 
> 38cc3c6dcc09 ("net: stmmac: protect updates of 64-bit statistics
> counters") allocates priv->xstats.pcpu_stats in stmmac_dvr_probe().
> 6.1 does not have 2eb85b750512 ("net: stmmac: don't clear network
> statistics in .ndo_open()"), so the memset() of priv->xstats in
> __stmmac_open() zeroes that pointer on every ifup, and the first DMA
> interrupt on a dwmac4 device (Tegra186/194 EQOS) dereferences a NULL
> percpu pointer.
> 
> Greg has queued a revert of the backport for 6.1, so this goes away in
> the next 6.1 release. 38cc3c6dcc09 can come back to 6.1 later together
> with 2eb85b750512.
> 
> Could you test if adding in 2eb85b750512 fixes the issue?


I confirmed that that does fix it.

Thanks
Jon

-- 
nvpublic


  reply	other threads:[~2026-11-02 14:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  7:33 Greg Kroah-Hartman
2026-10-29  8:29 ` Brett A C Sheffield
2026-10-29 10:10 ` Pavel Machek
2026-10-29 13:09 ` Miguel Ojeda
2026-10-29 14:42 ` Ron Economos
2026-10-29 14:47 ` SJ Park
2026-10-29 15:47 ` Peter Schneider
2026-10-29 18:16 ` Florian Fainelli
2026-10-30  8:47   ` Greg Kroah-Hartman
2026-10-30  8:01 ` Barry K. Nathan
     [not found] ` <b85e0697-d669-4b14-859f-52ee295264e4@rnnvmail201.nvidia.com>
2026-10-31  9:26   ` Jon Hunter
2026-10-31 14:41     ` Jon Hunter
2026-11-01 13:22       ` Greg Kroah-Hartman
2026-11-02 14:34         ` Jon Hunter
2026-11-03 14:51           ` Sasha Levin
2026-11-01 14:43       ` Sasha Levin
2026-11-02 14:34         ` Jon Hunter [this message]
2026-11-03 14:51           ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fd15777-fc45-4293-8255-c8d3d28a8156@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=achill@achill.org \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=conor@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hargar@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=patches@kernelci.org \
    --cc=patches@lists.linux.dev \
    --cc=pavel@nabladev.com \
    --cc=rwarsow@gmx.de \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=sr@sladewatkins.com \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®