mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: "James E. J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Part of Spinning up disk... ....ready logged on separate line and as warning (default level)
Date: Fri, 3 Dec 2021 15:48:51 +0100	[thread overview]
Message-ID: <8fdeecc3-bcce-1f5c-9aac-656fb3464c27@molgen.mpg.de> (raw)

Dear Linux folks,


Plugging in an external HDD over USB, Linux logs a warning:

     $ dmesg --level=warn
     [  244.677769] ....ready

With the messages around it:

     [  243.663382] sd 10:0:0:0: [sdb] Spinning up disk...
     [  244.677769] ....ready

The code in `drivers/scsi/sd.c` suggests that now line break should 
happen, as no `\n` is used and `printk(KERN_CONT ".")`. If that would 
work, the message would also be logged with level `KERN_NOTICE`.

Is the macro somehow getting in the way?

     sd_printk(KERN_NOTICE, sdkp, "Spinning up disk...");

 From `drivers/scsi/sd.h`:

```
#define sd_printk(prefix, sdsk, fmt, a...)                              \
         (sdsk)->disk ?                                                  \
               sdev_prefix_printk(prefix, (sdsk)->device,                \
                                  (sdsk)->disk->disk_name, fmt, ##a) :   \
               sdev_printk(prefix, (sdsk)->device, fmt, ##a)
```

 From `drivers/scsi/scsi_logging.c`:

```
void sdev_prefix_printk(const char *level, const struct scsi_device *sdev,
                         const char *name, const char *fmt, ...)
{
         va_list args;
         char *logbuf;
         size_t off = 0, logbuf_len;

         if (!sdev)
                 return;

         logbuf = scsi_log_reserve_buffer(&logbuf_len);
         if (!logbuf)
                 return;

         if (name)
                 off += scnprintf(logbuf + off, logbuf_len - off,
                                  "[%s] ", name);
         if (!WARN_ON(off >= logbuf_len)) {
                 va_start(args, fmt);
                 off += vscnprintf(logbuf + off, logbuf_len - off, fmt, 
args);
                 va_end(args);
         }
         dev_printk(level, &sdev->sdev_gendev, "%s", logbuf);
         scsi_log_release_buffer(logbuf);
}
EXPORT_SYMBOL(sdev_prefix_printk);
```

Also, there are four dots in `....ready`, but the log timestamps only 
differ by one seconds.

     /* Wait 1 second for next try */
     msleep(1000);
     printk(KERN_CONT ".");

Any idea, how that can be?


Kind regards,

Paul

             reply	other threads:[~2021-12-03 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 14:48 Paul Menzel [this message]
2021-12-07  4:13 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fdeecc3-bcce-1f5c-9aac-656fb3464c27@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®