mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
	"James E. J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Part of Spinning up disk... ....ready logged on separate line and as warning (default level)
Date: Mon, 6 Dec 2021 20:13:36 -0800	[thread overview]
Message-ID: <dc8d2a9d-69a7-c921-a995-d216e30ca2ee@acm.org> (raw)
In-Reply-To: <8fdeecc3-bcce-1f5c-9aac-656fb3464c27@molgen.mpg.de>

On 12/3/21 06:48, Paul Menzel wrote:
> Also, there are four dots in `....ready`, but the log timestamps only 
> differ by one seconds.
> 
>      /* Wait 1 second for next try */
>      msleep(1000);
>      printk(KERN_CONT ".");
> 
> Any idea, how that can be?

Not sure what is going on. All I know is that KERN_CONT is considered
deprecated and that it should be avoided. From commit 45c55e92fcee 
("checkpatch: warn on logging continuations"):

     pr_cont(...) and printk(KERN_CONT ...) uses should be discouraged
     as their output can be interleaved by multiple logging processes.

Thanks,

Bart.


      reply	other threads:[~2021-12-07  4:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 14:48 Paul Menzel
2021-12-07  4:13 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc8d2a9d-69a7-c921-a995-d216e30ca2ee@acm.org \
    --to=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®