mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jai Luthra <j-luthra@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, <nm@ti.com>,
	<devarsht@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	<niklas.soderlund+renesas@ragnatech.se>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Rob Herring <robh+dt@kernel.org>, Benoit Parrot <bparrot@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>, <devicetree@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 15/16] media: dt-bindings: Add TI J721E CSI2RX
Date: Mon, 31 Jul 2023 15:24:00 +0530	[thread overview]
Message-ID: <903337d5-2421-be7a-8b0b-9b684944f6a6@ti.com> (raw)
In-Reply-To: <169079588075.2176682.10224087620577481487.robh@kernel.org>

Hi Rob,

On 31/07/23 15:01, Rob Herring wrote:
> 
> On Mon, 31 Jul 2023 13:59:33 +0530, Jai Luthra wrote:
>> From: Pratyush Yadav <p.yadav@ti.com>
>>
>> TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate
>> capture over a CSI-2 bus. The TI CSI2RX platform driver glues all the
>> parts together.
>>
>> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
>> Signed-off-by: Jai Luthra <j-luthra@ti.com>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> v7->v8:
>> - Drop "Device Tree Bindings" from title
>> - Rename "Wrapper" to "Shim" in title as that is the name referred in
>>    the TRM and other places
>> - Update maintainer to myself
>> - Drop items from compatible as only a single element is present
>> - Rename compatible to "ti,j721e-csi2rx-shim" to distinguish from the
>>    SoC-specific CSI2RX bridge compatible
>>
>>   .../bindings/media/ti,j721e-csi2rx-shim.yaml       | 100 +++++++++++++++++++++
>>   1 file changed, 100 insertions(+)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.example.dtb: ticsi2rx@4500000: csi-bridge@4504000: False schema does not allow {'compatible': ['ti,j721e-csi2rx', 'cdns,csi2rx'], 'reg': [[72368128, 4096]], 'clocks': [[4294967295, 26, 2], [4294967295, 26, 0], [4294967295, 26, 2], [4294967295, 26, 2], [4294967295, 26, 3], [4294967295, 26, 3]], 'clock-names': ['sys_clk', 'p_clk', 'pixel_if0_clk', 'pixel_if1_clk', 'pixel_if2_clk', 'pixel_if3_clk'], 'phys': [[4294967295]], 'phy-names': ['dphy'], 'ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'endpoint': {'remote-endpoint': [[4294967295]], 'bus-type': [[4]], 'clock-lanes': [[0]], 'data-lanes': [[1, 2]]}}}}
> 	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
> Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.example.dtb: /example-0/ticsi2rx@4500000/csi-bridge@4504000: failed to match any schema with compatible: ['ti,j721e-csi2rx', 'cdns,csi2rx']
> Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.example.dtb: /example-0/ticsi2rx@4500000/csi-bridge@4504000: failed to match any schema with compatible: ['ti,j721e-csi2rx', 'cdns,csi2rx']
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230731-upstream_csi-v8-15-fb7d3661c2c9@ti.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.

Sorry I missed this warning from v7.

This patch depends on 9536cc949235 ("media: dt-bindings: cadence-csi2rx: 
Convert to DT schema") which is part of linux-next.

The base for this series should be linux-next/master 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
instead of 6.5-rc1.

> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

  reply	other threads:[~2023-07-31  9:55 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  8:29 [PATCH v8 00/16] CSI2RX support on J721E and AM62 Jai Luthra
2023-07-31  8:29 ` [PATCH v8 01/16] media: subdev: Export get_format helper for link validation Jai Luthra
2023-08-01 14:09   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 02/16] media: dt-bindings: Make sure items in data-lanes are unique Jai Luthra
2023-08-01 14:09   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 03/16] media: dt-bindings: cadence-csi2rx: Add TI compatible string Jai Luthra
2023-08-05 21:06   ` Krzysztof Kozlowski
2023-07-31  8:29 ` [PATCH v8 04/16] media: cadence: Add support for TI SoCs Jai Luthra
2023-08-05 21:06   ` Krzysztof Kozlowski
2023-08-07  7:58     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 05/16] media: cadence: csi2rx: Unregister v4l2 async notifier Jai Luthra
2023-08-01 14:11   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 06/16] media: cadence: csi2rx: Cleanup media entity properly Jai Luthra
2023-08-01 14:11   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 07/16] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Jai Luthra
2023-08-02  8:48   ` Tomi Valkeinen
2023-08-03 11:18     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 08/16] media: cadence: csi2rx: Configure DPHY using link freq Jai Luthra
2023-08-02  9:41   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 09/16] media: cadence: csi2rx: Soft reset the streams before starting capture Jai Luthra
2023-08-01 14:16   ` Tomi Valkeinen
2023-08-03 11:19     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 10/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Jai Luthra
2023-08-02  9:45   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 11/16] media: cadence: csi2rx: Fix stream data configuration Jai Luthra
2023-08-01 14:17   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 12/16] media: cadence: csi2rx: Populate subdev devnode Jai Luthra
2023-08-01 14:18   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 13/16] media: cadence: csi2rx: Add link validation Jai Luthra
2023-08-01 14:19   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 14/16] media: cadence: csi2rx: Support RAW8 and RAW10 formats Jai Luthra
2023-08-02  9:46   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 15/16] media: dt-bindings: Add TI J721E CSI2RX Jai Luthra
2023-07-31  9:31   ` Rob Herring
2023-07-31  9:54     ` Jai Luthra [this message]
2023-07-31  8:29 ` [PATCH v8 16/16] media: ti: Add CSI2RX support for J721E Jai Luthra
2023-08-02 11:04   ` Tomi Valkeinen
2023-08-02 11:14     ` Sakari Ailus
2023-08-02 12:09       ` Tomi Valkeinen
2023-08-03 11:51     ` Jai Luthra
2023-07-31 12:11 ` [PATCH v8 00/16] CSI2RX support on J721E and AM62 Maxime Ripard
2023-08-08 22:55 ` Vaishnav Achath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=903337d5-2421-be7a-8b0b-9b684944f6a6@ti.com \
    --to=j-luthra@ti.com \
    --cc=bparrot@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®