From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Jai Luthra <j-luthra@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
niklas.soderlund+renesas@ragnatech.se,
Benoit Parrot <bparrot@ti.com>,
Vaishnav Achath <vaishnav.a@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
nm@ti.com, devarsht@ti.com
Subject: Re: [PATCH v8 16/16] media: ti: Add CSI2RX support for J721E
Date: Wed, 2 Aug 2023 11:14:10 +0000 [thread overview]
Message-ID: <ZMo6gtN/4sQz44tH@kekkonen.localdomain> (raw)
In-Reply-To: <d5d9f2cb-9879-9f25-9b5c-b3b43d551658@ideasonboard.com>
Moi,
On Wed, Aug 02, 2023 at 02:04:57PM +0300, Tomi Valkeinen wrote:
> > +static int ti_csi2rx_enum_fmt_vid_cap(struct file *file, void *priv,
> > + struct v4l2_fmtdesc *f)
> > +{
> > + const struct ti_csi2rx_fmt *fmt = NULL;
> > +
> > + if (f->mbus_code) {
> > + if (f->index > 0)
> > + return -EINVAL;
>
> This fails to enumerate the formats if mbus_code is set, doesn't it?
This is intentional: if the mbus_code field is set, you're supposed to get
only format(s) corresponding to that mbus code.
>
> > +
> > + fmt = find_format_by_code(f->mbus_code);
> > + } else {
> > + if (f->index >= num_formats)
> > + return -EINVAL;
> > +
> > + fmt = &formats[f->index];
> > + }
> > +
> > + if (!fmt)
> > + return -EINVAL;
> > +
> > + f->pixelformat = fmt->fourcc;
> > + memset(f->reserved, 0, sizeof(f->reserved));
> > + f->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
> > +
> > + return 0;
> > +}
--
Sakari Ailus
next prev parent reply other threads:[~2023-08-02 11:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 8:29 [PATCH v8 00/16] CSI2RX support on J721E and AM62 Jai Luthra
2023-07-31 8:29 ` [PATCH v8 01/16] media: subdev: Export get_format helper for link validation Jai Luthra
2023-08-01 14:09 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 02/16] media: dt-bindings: Make sure items in data-lanes are unique Jai Luthra
2023-08-01 14:09 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 03/16] media: dt-bindings: cadence-csi2rx: Add TI compatible string Jai Luthra
2023-08-05 21:06 ` Krzysztof Kozlowski
2023-07-31 8:29 ` [PATCH v8 04/16] media: cadence: Add support for TI SoCs Jai Luthra
2023-08-05 21:06 ` Krzysztof Kozlowski
2023-08-07 7:58 ` Jai Luthra
2023-07-31 8:29 ` [PATCH v8 05/16] media: cadence: csi2rx: Unregister v4l2 async notifier Jai Luthra
2023-08-01 14:11 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 06/16] media: cadence: csi2rx: Cleanup media entity properly Jai Luthra
2023-08-01 14:11 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 07/16] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Jai Luthra
2023-08-02 8:48 ` Tomi Valkeinen
2023-08-03 11:18 ` Jai Luthra
2023-07-31 8:29 ` [PATCH v8 08/16] media: cadence: csi2rx: Configure DPHY using link freq Jai Luthra
2023-08-02 9:41 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 09/16] media: cadence: csi2rx: Soft reset the streams before starting capture Jai Luthra
2023-08-01 14:16 ` Tomi Valkeinen
2023-08-03 11:19 ` Jai Luthra
2023-07-31 8:29 ` [PATCH v8 10/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Jai Luthra
2023-08-02 9:45 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 11/16] media: cadence: csi2rx: Fix stream data configuration Jai Luthra
2023-08-01 14:17 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 12/16] media: cadence: csi2rx: Populate subdev devnode Jai Luthra
2023-08-01 14:18 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 13/16] media: cadence: csi2rx: Add link validation Jai Luthra
2023-08-01 14:19 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 14/16] media: cadence: csi2rx: Support RAW8 and RAW10 formats Jai Luthra
2023-08-02 9:46 ` Tomi Valkeinen
2023-07-31 8:29 ` [PATCH v8 15/16] media: dt-bindings: Add TI J721E CSI2RX Jai Luthra
2023-07-31 9:31 ` Rob Herring
2023-07-31 9:54 ` Jai Luthra
2023-07-31 8:29 ` [PATCH v8 16/16] media: ti: Add CSI2RX support for J721E Jai Luthra
2023-08-02 11:04 ` Tomi Valkeinen
2023-08-02 11:14 ` Sakari Ailus [this message]
2023-08-02 12:09 ` Tomi Valkeinen
2023-08-03 11:51 ` Jai Luthra
2023-07-31 12:11 ` [PATCH v8 00/16] CSI2RX support on J721E and AM62 Maxime Ripard
2023-08-08 22:55 ` Vaishnav Achath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMo6gtN/4sQz44tH@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=bparrot@ti.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®