Re: [PATCH v4 1/9] dt-bindings: soc: renesas: Document RZ/V2H EVK board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/08/2024 09:35, Geert Uytterhoeven wrote:
> Good mornin' Krzysztof,
> 
> On Thu, Aug 29, 2024 at 8:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 28/08/2024 22:09, Lad, Prabhakar wrote:
>>> On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> On 28/08/2024 14:41, Prabhakar wrote:
>>>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>>> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
>>>>> EVK board.
>>>>>
>>>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>>>> ---
>>>>> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
>>>>>
>>>>> Cheers, Prabhakar
>>>>>
>>>>> v1->v4
>>>>> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
>>>>> - Updated commit message
>>>>>
>>>>> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
>>>>> ---
>>>>>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> index d582992aaf0e..b7acb65bdecd 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> @@ -527,6 +527,8 @@ properties:
>>>>>
>>>>>        - description: RZ/V2H(P) (R9A09G057)
>>>>>          items:
>>>>> +          - enum:
>>>>> +              - renesas,rzv2h-evk # RZ/V2H EVK
>>>>>            - enum:
>>>>
>>>> This is unusual pattern for me, but maybe I miss here something. Commit
>>>> message does not explain why EXISTING boards needs to be changed. What
>>>> does it mean "rzv2h-evk targets evk board"? How does this work?
>>>>
>>> This commit is not changing the existing boards. The entries below the
>>> addition are the RZ/V2H(P) SoC variants. Here we are just adding the
>>> board entry which is based on RZ/V2H SoC [0].
>>
>> Then it is even more surprising to see there entries which were not
>> boards. What's in this file in such case?
> 
> Before this patch, the entry that is being modified just contained
> SoC variants and a fallback SoC type.
> This patch documents the compatible value for the first board based
> on an SoC of this type.
> 
>> Which DTS file it matches?
> 
> The one that is introduced in patch 3/9  in this series.

So the binding had compatibles without board-part and obviously there
were no board-DTS files with them.

That's a less usual, so short explanation in commit msg would be helpful.

Best regards,
Krzysztof