From: Alex Elder <elder@riscstar.com>
To: sboyd@kernel.org, bmasney+clk@redhat.com,
jbrunet+clk@baylibre.com, p.zabel@pengutronix.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com,
lorenzo.bianconi@oss.qualcomm.com, fabrice.gasnier@foss.st.com,
alexandre.torgue@foss.st.com, marex@nabladev.com,
changhuang.liang@starfivetech.com, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] soc: toshiba: tc9564: config system controller
Date: Thu, 19 Nov 2026 20:36:26 -0600 [thread overview]
Message-ID: <9066bc1a-3b92-4608-b925-e362847dd1c9@riscstar.com> (raw)
In-Reply-To: <20261104004332.2141282-1-elder@riscstar.com>
On 11/3/26 6:43 PM, Alex Elder wrote:
> This series is comprised of some code that was previously sent
> separately. It now incorporates a new system controller driver
> that advertises clock and reset functionality, as well as regmap
> access to its address range. This combination is being treated
> as a new series. (Details of previous versions are below.)
>
> The Toshiba TC9564 is an SoC that attaches to a host system via PCIe.
> It includes a PCIe switch with three downstream ports. To one of
> these ports an embedded PCIe endpoint is attached, and that implements
> two PCI functions. BAR 4 for both PCI functions provides access to
> registers controlling blocks within the SoC.
>
> The system controller driver adds the clock and reset devices
> using the mfd_add_devices() interface. The clocks and resets
> are implemented by drivers included in this series.
Krzysztof Kozlowski questioned the use of the syscon for this
chip, and after some offline discussion I agreed to go without
it. This means Conor's ack won't be included, and I won't be
doing anything I said I would that was related to the syscon.
The clock and reset drivers can each stand alone, without
using a shared regmap.
Each of these drivers uses two registers. But in both cases,
the two registers are discontiguous:
clock: 0x1004 and 0x100c
reset: 0x1008 and 0x1010
It has been suggested before that separating the reset and
clock drivers has advantages, but I think in this case, the
simplicity of the combined driver (especially because of the
interleaved registers) is the better option.
For that reason, I intend to *combine* these two drivers into
a single clock controller driver that provides both clocks
and resets. The source code will reside under drivers/clk.
The combined device will have a single DTS node, defined by
a single devicetree binding, and will use a single contiguous
address range:
clock+reset: base 0x1004, size 0x10
The next version of this series would have no syscon, and
with the clock and reset support combined, it will basically
be a new series. I'll provide links back to this and older
code, but the next iteration will consist of:
- A single devicetree binding for the clock+reset combined.
- A header file defining clock and reset IDs, here:
include/dt-bindings/clock/toshiba,tc9564.h
- A single source file, drivers/clk/clk-tc9564.c (plus
updates for Kconfig and Makefile)
-Alex
>
> -Alex
>
> The system controller, along with its devicetree binding are new.
> My hope is that this new model addresses concerns that Krzysztof
> Kozlowski has expressed in prior versions of the clock and reset
> code ("fold into the parent").
>
> The clock controller driver was last posted as version 3, and all
> feedback from prior versions has been addressed. This driver has
> essentially been completely rewritten. There are now three clock
> types (PLL, fixed factor, and gate), and each defined clock has
> a parent, and the is_enabled callback is implemented for the gate
> clocks.
>
> The last version of the clock driver is here:
> https://lore.kernel.org/lkml/20261012152408.3729237-1-elder@riscstar.com/
>
> The reset controller driver was last posted as version 1. All
> feedback received on that version has been addressed, and it's
> a bit simpler than before.
>
> The last version of the reset driver is here:
> https://lore.kernel.org/lkml/20261012164354.3872326-1-elder@riscstar.com/
>
> Alex Elder (4):
> dt-bindings: soc: introduce toshiba,tc9564-config-syscon.yaml
> soc: toshiba: tc9564: add a new syscon driver
> clk: toshiba: introduce a TC9564 SoC clock driver
> reset: toshiba: introduce a TC9564 SoC reset driver
>
> .../toshiba/toshiba,tc9564-config-syscon.yaml | 68 +++++
> MAINTAINERS | 23 ++
> drivers/clk/Kconfig | 12 +
> drivers/clk/Makefile | 1 +
> drivers/clk/clk-tc9564.c | 288 ++++++++++++++++++
> drivers/reset/Kconfig | 12 +
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-tc9564.c | 135 ++++++++
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/toshiba/Kconfig | 12 +
> drivers/soc/toshiba/Makefile | 3 +
> drivers/soc/toshiba/tc9564-syscon.c | 42 +++
> include/dt-bindings/soc/toshiba,tc9564.h | 46 +++
> 14 files changed, 645 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/toshiba/toshiba,tc9564-config-syscon.yaml
> create mode 100644 drivers/clk/clk-tc9564.c
> create mode 100644 drivers/reset/reset-tc9564.c
> create mode 100644 drivers/soc/toshiba/Kconfig
> create mode 100644 drivers/soc/toshiba/Makefile
> create mode 100644 drivers/soc/toshiba/tc9564-syscon.c
> create mode 100644 include/dt-bindings/soc/toshiba,tc9564.h
>
>
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
prev parent reply other threads:[~2026-11-20 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 0:43 Alex Elder
2026-11-04 0:43 ` [PATCH 1/4] dt-bindings: soc: introduce toshiba,tc9564-config-syscon.yaml Alex Elder
2026-11-05 0:25 ` Conor Dooley
2026-11-05 0:28 ` Conor Dooley
2026-11-05 2:09 ` Alex Elder
2026-11-05 20:23 ` Krzysztof Kozlowski
2026-11-09 17:41 ` Alex Elder
2026-11-12 9:04 ` Krzysztof Kozlowski
2026-11-04 0:43 ` [PATCH 2/4] soc: toshiba: tc9564: add a new syscon driver Alex Elder
2026-11-12 9:01 ` Krzysztof Kozlowski
2026-11-04 0:43 ` [PATCH 3/4] clk: toshiba: introduce a TC9564 SoC clock driver Alex Elder
2026-11-13 19:09 ` Jerome Brunet
2026-11-20 2:34 ` Alex Elder
2026-11-04 0:43 ` [PATCH 4/4] reset: toshiba: introduce a TC9564 SoC reset driver Alex Elder
2026-11-04 9:49 ` Philipp Zabel
2026-11-04 21:22 ` Alex Elder
2026-11-05 20:26 ` [PATCH 0/4] soc: toshiba: tc9564: config system controller Krzysztof Kozlowski
2026-11-06 1:50 ` Alex Elder
2026-11-09 17:42 ` Alex Elder
2026-11-12 9:01 ` Krzysztof Kozlowski
2026-11-20 2:36 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9066bc1a-3b92-4608-b925-e362847dd1c9@riscstar.com \
--to=elder@riscstar.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bmasney+clk@redhat.com \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=daniel@riscstar.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=marex@nabladev.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®