From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guangshuo Li" <lgs201920130244@gmail.com>,
"Lee, Chun-Yi" <jlee@suse.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Matthew Garrett" <mjg@redhat.com>, "Marek Vasut" <marex@denx.de>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] platform/x86: acer-wmi: fix UAF after accelerometer registration failure
Date: Tue, 27 Oct 2026 16:33:07 +0100 [thread overview]
Message-ID: <908cb70d-bfe8-4d01-b64e-44ffcfe259bd@kernel.org> (raw)
In-Reply-To: <20261026111103.4158855-1-lgs201920130244@gmail.com>
On 26/10/2026 12:11, Guangshuo Li wrote:
> When input_register_device() fails in acer_wmi_accel_setup(), the error
> path frees acer_wmi_accel_dev but leaves the global pointer non-NULL.
>
> Since acer_wmi_init() ignores the accelerometer setup failure and
> continues initialization, a later driver removal or initialization
> failure can call input_unregister_device() on the dangling pointer,
> resulting in a use-after-free.
>
> Set acer_wmi_accel_dev to NULL after freeing it so that the cleanup
> paths do not attempt to unregister the already-freed input device.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: 1eb3fe1d3b6b ("ACER: Add support for accelerometer sensor")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---
So you just keep ignoring and ignoring our feedback. It's just bot, so
little point to discuss with bot.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-27 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:11 Guangshuo Li
2026-10-27 15:33 ` Krzysztof Kozlowski [this message]
2026-10-27 16:23 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=908cb70d-bfe8-4d01-b64e-44ffcfe259bd@kernel.org \
--to=krzk@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®