From: Gabriele Monaco <gmonaco@redhat.com>
To: Nam Cao <namcao@linutronix.de>
Cc: Wen Yang <wen.yang@linux.dev>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/12] rv: Fix read_lock scope in per-task DA cleanup
Date: Fri, 29 May 2026 08:08:12 +0200 [thread overview]
Message-ID: <90bedf1a51a12b2f2fab4a34b3f2402c33fa4f34.camel@redhat.com> (raw)
In-Reply-To: <87ldd3orft.fsf@yellow.woof>
On Thu, 2026-05-28 at 10:43 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@redhat.com> writes:
> > The da_monitor_reset_all() function for per-task monitors takes
> > tasklist_lock while iterating over tasks, then keeps it also while
> > iterating over idle tasks (one per CPU). The latter is not
> > necessary
> > since the lock needs to guard only for_each_process_thread().
> >
> > Use a scoped_guard for more compact syntax and adjust the scope
> > only
> > where the lock is necessary.
> >
> > Fixes: 30984ccf31b7f ("rv: Refactor da_monitor to minimise macros")
> > Fixes: 8259cb14a7068 ("rv: Reset per-task monitors also for idle
> > tasks")
>
> Fixes: tag "indicates that the patch fixes a bug in a previous
> commit". There is no bug here, so I don't think Fixes tags are
> applicable.
Yeah good point, that isn't a real bug.. We're just holding a lock for
a bit too long but there's no harm in that. Will remove the tags.
Thanks,
Gabriele
>
> > Reviewed-by: Wen Yang <wen.yang@linux.dev>
> > Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
>
> Reviewed-by: Nam Cao <namcao@linutronix.de>
next prev parent reply other threads:[~2026-05-29 6:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 6:23 [PATCH v2 00/12] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 01/12] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-28 8:38 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 02/12] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-28 8:43 ` Nam Cao
2026-05-29 6:08 ` Gabriele Monaco [this message]
2026-05-27 6:23 ` [PATCH v2 03/12] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-05-28 8:48 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 04/12] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-28 8:56 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 05/12] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-28 8:59 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 06/12] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-28 9:01 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 07/12] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-28 9:09 ` Nam Cao
2026-05-31 14:54 ` Wen Yang
2026-05-27 6:23 ` [PATCH v2 08/12] rv: Ensure synchronous cleanup for HA monitors Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 09/12] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 10/12] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 11/12] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 12/12] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90bedf1a51a12b2f2fab4a34b3f2402c33fa4f34.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®