From: Jyri Sarha <jsarha@ti.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Airlie <airlied@linux.ie>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning
Date: Mon, 12 Sep 2016 11:24:47 +0300 [thread overview]
Message-ID: <90cd5805-32a1-2b9a-dd4b-abd477d9c90e@ti.com> (raw)
In-Reply-To: <1473510777-25444-1-git-send-email-weiyj.lk@gmail.com>
On 09/10/16 15:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
> symbol 'tilcdc_atomic_check' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I'll pick this up.
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..dc58770 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
> drm_fbdev_cma_hotplug_event(priv->fbdev);
> }
>
> -int tilcdc_atomic_check(struct drm_device *dev,
> - struct drm_atomic_state *state)
> +static int tilcdc_atomic_check(struct drm_device *dev,
> + struct drm_atomic_state *state)
> {
> int ret;
>
>
>
>
prev parent reply other threads:[~2016-09-12 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 12:32 Wei Yongjun
2016-09-12 8:24 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90cd5805-32a1-2b9a-dd4b-abd477d9c90e@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®