* [PATCH -next] nullb: fix error return code in null_init()
@ 2017-10-17 12:11 Wei Yongjun
2017-10-17 14:25 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-10-17 12:11 UTC (permalink / raw)
To: matias, axboe, shli, kkc6196, bart.vanassche, zhangweiping
Cc: Wei Yongjun, linux-kernel
Fix to return error code -ENOMEM from the null_alloc_dev() error
handling case instead of 0, as done elsewhere in this function.
Fixes: 2984c8684f96 ("nullb: factor disk parameters")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/block/null_blk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index bf2c8ca..50c83c4 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -1991,8 +1991,10 @@ static int __init null_init(void)
for (i = 0; i < nr_devices; i++) {
dev = null_alloc_dev();
- if (!dev)
+ if (!dev) {
+ ret = -ENOMEM;
goto err_dev;
+ }
ret = null_add_dev(dev);
if (ret) {
null_free_dev(dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nullb: fix error return code in null_init()
2017-10-17 12:11 [PATCH -next] nullb: fix error return code in null_init() Wei Yongjun
@ 2017-10-17 14:25 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2017-10-17 14:25 UTC (permalink / raw)
To: Wei Yongjun, matias, shli, kkc6196, bart.vanassche, zhangweiping
Cc: linux-kernel
On 10/17/2017 06:11 AM, Wei Yongjun wrote:
> Fix to return error code -ENOMEM from the null_alloc_dev() error
> handling case instead of 0, as done elsewhere in this function.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 12:11 [PATCH -next] nullb: fix error return code in null_init() Wei Yongjun
2017-10-17 14:25 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®