From: Dan Nicholson <dbn.lists@gmail.com>
To: John Kacur <jkacur@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@linux.ie>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jerome Glisse <jglisse@redhat.com>,
Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>,
dri-devel <dri-devel@lists.sf.net>,
Alex Deucher <alexdeucher@gmail.com>,
Kevin Winchester <kjwinchester@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] radeon_agp: Fix warning, format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’
Date: Sun, 31 Jan 2010 11:02:43 -0800 [thread overview]
Message-ID: <91705d081001311102m63cb3edfib8df864ca580e736@mail.gmail.com> (raw)
In-Reply-To: <1264884670-28211-2-git-send-email-jkacur@redhat.com>
On Sat, Jan 30, 2010 at 12:51 PM, John Kacur <jkacur@redhat.com> wrote:
> Fix warning by using %zu instead of %d for size_t
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
> drivers/gpu/drm/radeon/radeon_agp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
> index c9ad7f5..1c4e523 100644
> --- a/drivers/gpu/drm/radeon/radeon_agp.c
> +++ b/drivers/gpu/drm/radeon/radeon_agp.c
> @@ -134,7 +134,7 @@ int radeon_agp_init(struct radeon_device *rdev)
> int ret;
>
> if (rdev->ddev->agp->agp_info.aper_size < 32) {
> - dev_warn(rdev->dev, "AGP aperture to small (%dM) "
> + dev_warn(rdev->dev, "AGP aperture to small (%zuM) "
As long as you're fixing this line, you might want to correct the
grammar s/to/too/.
--
Dan
next prev parent reply other threads:[~2010-01-31 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 20:51 [PATCH] radeon_agp_init fixes John Kacur
2010-01-30 20:51 ` [PATCH] radeon_agp: Fix warning, format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’ John Kacur
2010-01-31 19:02 ` Dan Nicholson [this message]
2010-01-31 19:29 ` John Kacur
2010-01-30 20:51 ` [PATCH] radeon_agp: Move the check of the aper_size after drm_acp_acquire and drm_agp_info John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91705d081001311102m63cb3edfib8df864ca580e736@mail.gmail.com \
--to=dbn.lists@gmail.com \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.sf.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jglisse@redhat.com \
--cc=jkacur@redhat.com \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®