Re: [PATCH] radeon_agp: Fix warning, format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’

[John Kacur <jkacur@redhat.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1191 bytes --]



On Sun, 31 Jan 2010, Dan Nicholson wrote:

> On Sat, Jan 30, 2010 at 12:51 PM, John Kacur <jkacur@redhat.com> wrote:
> > Fix warning by using %zu instead of %d for size_t
> >
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> >  drivers/gpu/drm/radeon/radeon_agp.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
> > index c9ad7f5..1c4e523 100644
> > --- a/drivers/gpu/drm/radeon/radeon_agp.c
> > +++ b/drivers/gpu/drm/radeon/radeon_agp.c
> > @@ -134,7 +134,7 @@ int radeon_agp_init(struct radeon_device *rdev)
> >        int ret;
> >
> >        if (rdev->ddev->agp->agp_info.aper_size < 32) {
> > -               dev_warn(rdev->dev, "AGP aperture to small (%dM) "
> > +               dev_warn(rdev->dev, "AGP aperture to small (%zuM) "
> 
> As long as you're fixing this line, you might want to correct the
> grammar s/to/too/.

Thanks, I saw that too, after I sent. Unfortunately, I have to respin both 
patches, because there is a merge conflict after fixing the 
grammar/spelling mistake.

Both patches coming up, in a separate mail.

John