* [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check
@ 2026-09-10 14:26 Rokinthan p
2026-09-11 9:40 ` Hans Verkuil
2026-09-11 9:42 ` Hans Verkuil
0 siblings, 2 replies; 4+ messages in thread
From: Rokinthan p @ 2026-09-10 14:26 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, cf896de36144391bcde1,
syzbot+9f7405999979761b6cfc
In hackrf_probe(), v4l2_ctrl_auto_cluster() is called immediately after
allocating the auto and manual bandwidth controls for both the receiver
and transmitter.
If allocating the master control (dev->rx_bandwidth_auto or
dev->tx_bandwidth_auto) fails, e.g. due to memory allocation failure,
the pointer is NULL and the error is recorded in the control handler.
Calling v4l2_ctrl_auto_cluster() with a NULL master control causes
v4l2_ctrl_cluster() to trigger a WARNING:
ncontrols == 0 || controls[0] == NULL
WARNING: drivers/media/v4l2-core/v4l2-ctrls-core.c:2525 at
v4l2_ctrl_cluster
Fix this by moving the v4l2_ctrl_auto_cluster() invocations down after
checking dev->rx_ctrl_handler.error and dev->tx_ctrl_handler.error.
If control allocation fails, probe cleanly aborts with an error without
attempting to cluster NULL controls.
Fixes: 969ec1f6bd92 ("[media] hackrf: HackRF SDR driver")
Reported-by: syzbot+cf896de36144391bcde1@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=cf896de36144391bcde1
Signed-off-by: Rohinthan <rokinthanp03@gmail.com>
---
v1 -> v2:
- Correct the Fixes tag commit hash and title to match git history
- Fix email formatting and whitespace
drivers/media/usb/hackrf/hackrf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c
b/drivers/media/usb/hackrf/hackrf.c
--- a/drivers/media/usb/hackrf/hackrf.c
+++ b/drivers/media/usb/hackrf/hackrf.c
@@ -1427,7 +1427,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12,
12, 0);
dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
@@ -1439,6 +1438,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_rx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->rx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
@@ -1450,7 +1450,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47,
1, 0);
dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
@@ -1460,6 +1459,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_tx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->tx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check
2026-09-10 14:26 [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check Rokinthan p
@ 2026-09-11 9:40 ` Hans Verkuil
2026-09-11 9:42 ` Hans Verkuil
1 sibling, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2026-09-11 9:40 UTC (permalink / raw)
To: www.rokinthanp03, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, cf896de36144391bcde1,
syzbot+9f7405999979761b6cfc
Hi Rokinthan,
On 10/09/2026 16:26, Rokinthan p wrote:
> In hackrf_probe(), v4l2_ctrl_auto_cluster() is called immediately after
> allocating the auto and manual bandwidth controls for both the receiver
> and transmitter.
>
> If allocating the master control (dev->rx_bandwidth_auto or
> dev->tx_bandwidth_auto) fails, e.g. due to memory allocation failure,
> the pointer is NULL and the error is recorded in the control handler.
> Calling v4l2_ctrl_auto_cluster() with a NULL master control causes
> v4l2_ctrl_cluster() to trigger a WARNING:
>
> ncontrols == 0 || controls[0] == NULL
> WARNING: drivers/media/v4l2-core/v4l2-ctrls-core.c:2525 at
> v4l2_ctrl_cluster
>
> Fix this by moving the v4l2_ctrl_auto_cluster() invocations down after
> checking dev->rx_ctrl_handler.error and dev->tx_ctrl_handler.error.
> If control allocation fails, probe cleanly aborts with an error without
> attempting to cluster NULL controls.
Your analysis is correct, but the fix should actually be done in the v4l2-ctrls-core.c
source.
If controls[0] is NULL, then both v4l2_ctrl_cluster and v4l2_ctrl_auto_cluster
should just return 0 since something clearly went wrong when the master control
was created.
This will be caught at the end in the driver code when hdl->error is checked.
The code snippet for Control Clusters in Documentation/driver-api/media/v4l2-controls.rst
clearly shows that that was how it was intended (i.e. state->audio_cluster[0]
might be NULL, but it is still passed without checking to v4l2_ctrl_cluster).
The design has always been that you can just create controls as you go and just
check for hdl->error at the end. It saves a lot of unnecessary checks. And
v4l2_ctrl_cluster/v4l2_ctrl_auto_cluster break that scheme.
So can you make a patch that adds that NULL pointer check? And also update
the function documentation in include/media/v4l2-ctrls.h to make it clear
it just returns if controls[0] == NULL.
Fixing this in hackrf just papers over the root cause, and there are almost
certainly more drivers that do not check the master control before calling
v4l2_ctrl_cluster/v4l2_ctrl_auto_cluster.
And BTW, your patch is still mangled.
Regards,
Hans
>
> Fixes: 969ec1f6bd92 ("[media] hackrf: HackRF SDR driver")
> Reported-by: syzbot+cf896de36144391bcde1@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=cf896de36144391bcde1
> Signed-off-by: Rohinthan <rokinthanp03@gmail.com>
> ---
> v1 -> v2:
> - Correct the Fixes tag commit hash and title to match git history
> - Fix email formatting and whitespace
>
> drivers/media/usb/hackrf/hackrf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/hackrf/hackrf.c
> b/drivers/media/usb/hackrf/hackrf.c
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -1427,7 +1427,6 @@ static int hackrf_probe(struct usb_interface *intf,
> dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> &hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
> 1750000, 28000000, 50000, 1750000);
> - v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
> dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> &hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12,
> 12, 0);
> dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> @@ -1439,6 +1438,7 @@ static int hackrf_probe(struct usb_interface *intf,
> dev_err(dev->dev, "Could not initialize controls\n");
> goto err_v4l2_ctrl_handler_free_rx;
> }
> + v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
> v4l2_ctrl_grab(dev->rx_rf_gain, !hackrf_enable_rf_gain_ctrl);
> v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
>
> @@ -1450,7 +1450,6 @@ static int hackrf_probe(struct usb_interface *intf,
> dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> &hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
> 1750000, 28000000, 50000, 1750000);
> - v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
> dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> &hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47,
> 1, 0);
> dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> @@ -1460,6 +1459,7 @@ static int hackrf_probe(struct usb_interface *intf,
> dev_err(dev->dev, "Could not initialize controls\n");
> goto err_v4l2_ctrl_handler_free_tx;
> }
> + v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
> v4l2_ctrl_grab(dev->tx_rf_gain, !hackrf_enable_rf_gain_ctrl);
> v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check
2026-09-10 14:26 [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check Rokinthan p
2026-09-11 9:40 ` Hans Verkuil
@ 2026-09-11 9:42 ` Hans Verkuil
1 sibling, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2026-09-11 9:42 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rokinthan p
Cc: linux-media, linux-kernel, cf896de36144391bcde1,
syzbot+9f7405999979761b6cfc
[Resend, fixing a weird 'Reply-to' email, I hope it works this time)
Hi Rokinthan,
On 10/09/2026 16:26, Rokinthan p wrote:
> In hackrf_probe(), v4l2_ctrl_auto_cluster() is called immediately after
> allocating the auto and manual bandwidth controls for both the receiver
> and transmitter.
>
> If allocating the master control (dev->rx_bandwidth_auto or
> dev->tx_bandwidth_auto) fails, e.g. due to memory allocation failure,
> the pointer is NULL and the error is recorded in the control handler.
> Calling v4l2_ctrl_auto_cluster() with a NULL master control causes
> v4l2_ctrl_cluster() to trigger a WARNING:
>
> ncontrols == 0 || controls[0] == NULL
> WARNING: drivers/media/v4l2-core/v4l2-ctrls-core.c:2525 at
> v4l2_ctrl_cluster
>
> Fix this by moving the v4l2_ctrl_auto_cluster() invocations down after
> checking dev->rx_ctrl_handler.error and dev->tx_ctrl_handler.error.
> If control allocation fails, probe cleanly aborts with an error without
> attempting to cluster NULL controls.
Your analysis is correct, but the fix should actually be done in the v4l2-ctrls-core.c
source.
If controls[0] is NULL, then both v4l2_ctrl_cluster and v4l2_ctrl_auto_cluster
should just return 0 since something clearly went wrong when the master control
was created.
This will be caught at the end in the driver code when hdl->error is checked.
The code snippet for Control Clusters in Documentation/driver-api/media/v4l2-controls.rst
clearly shows that that was how it was intended (i.e. state->audio_cluster[0]
might be NULL, but it is still passed without checking to v4l2_ctrl_cluster).
The design has always been that you can just create controls as you go and just
check for hdl->error at the end. It saves a lot of unnecessary checks. And
v4l2_ctrl_cluster/v4l2_ctrl_auto_cluster break that scheme.
So can you make a patch that adds that NULL pointer check? And also update
the function documentation in include/media/v4l2-ctrls.h to make it clear
it just returns if controls[0] == NULL.
Fixing this in hackrf just papers over the root cause, and there are almost
certainly more drivers that do not check the master control before calling
v4l2_ctrl_cluster/v4l2_ctrl_auto_cluster.
And BTW, your patch is still mangled.
Regards,
Hans
>
> Fixes: 969ec1f6bd92 ("[media] hackrf: HackRF SDR driver")
> Reported-by: syzbot+cf896de36144391bcde1@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=cf896de36144391bcde1
> Signed-off-by: Rohinthan <rokinthanp03@gmail.com>
> ---
> v1 -> v2:
> - Correct the Fixes tag commit hash and title to match git history
> - Fix email formatting and whitespace
>
> drivers/media/usb/hackrf/hackrf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/hackrf/hackrf.c
> b/drivers/media/usb/hackrf/hackrf.c
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -1427,7 +1427,6 @@ static int hackrf_probe(struct usb_interface *intf,
> dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> &hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
> 1750000, 28000000, 50000, 1750000);
> - v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
> dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> &hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12,
> 12, 0);
> dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
> @@ -1439,6 +1438,7 @@ static int hackrf_probe(struct usb_interface *intf,
> dev_err(dev->dev, "Could not initialize controls\n");
> goto err_v4l2_ctrl_handler_free_rx;
> }
> + v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
> v4l2_ctrl_grab(dev->rx_rf_gain, !hackrf_enable_rf_gain_ctrl);
> v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
>
> @@ -1450,7 +1450,6 @@ static int hackrf_probe(struct usb_interface *intf,
> dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> &hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
> 1750000, 28000000, 50000, 1750000);
> - v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
> dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> &hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47,
> 1, 0);
> dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
> @@ -1460,6 +1459,7 @@ static int hackrf_probe(struct usb_interface *intf,
> dev_err(dev->dev, "Could not initialize controls\n");
> goto err_v4l2_ctrl_handler_free_tx;
> }
> + v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
> v4l2_ctrl_grab(dev->tx_rf_gain, !hackrf_enable_rf_gain_ctrl);
> v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check
@ 2026-09-10 12:34 Rokinthan p
0 siblings, 0 replies; 4+ messages in thread
From: Rokinthan p @ 2026-09-10 12:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, cf896de36144391bcde1,
syzbot+9f7405999979761b6cfc
[-- Attachment #1: Type: text/plain, Size: 3422 bytes --]
In hackrf_probe(), v4l2_ctrl_auto_cluster() is called immediately after
allocating the auto and manual bandwidth controls for both the receiver
and transmitter.
If allocating the master control (dev->rx_bandwidth_auto or
dev->tx_bandwidth_auto) fails, e.g. due to memory allocation failure,
the pointer is NULL and the error is recorded in the control handler.
Calling v4l2_ctrl_auto_cluster() with a NULL master control causes
v4l2_ctrl_cluster() to trigger a WARNING:
ncontrols == 0 || controls[0] == NULL
WARNING: drivers/media/v4l2-core/v4l2-ctrls-core.c:2525 at
v4l2_ctrl_cluster
Fix this by moving the v4l2_ctrl_auto_cluster() invocations down after
checking dev->rx_ctrl_handler.error and dev->tx_ctrl_handler.error.
If control allocation fails, probe cleanly aborts with an error without
attempting to cluster NULL controls.
Fixes: 81774395a8d9 ("[media] hackrf: new driver")
Reported-by: syzbot+cf896de36144391bcde1@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=cf896de36144391bcde1
Signed-off-by: Rohinthan <rokinthanp03@gmail.com>
---
v1 -> v2: Fix email indentation and whitespace corruption from initial
submission.
drivers/media/usb/hackrf/hackrf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c
b/drivers/media/usb/hackrf/hackrf.c
--- a/drivers/media/usb/hackrf/hackrf.c
+++ b/drivers/media/usb/hackrf/hackrf.c
@@ -1427,7 +1427,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12,
12, 0);
dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
@@ -1439,6 +1438,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_rx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->rx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
@@ -1450,7 +1450,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47,
1, 0);
dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
@@ -1460,6 +1459,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_tx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->tx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
[-- Attachment #2: 0001-media-hackrf-defer-v4l2_ctrl_auto_cluster-until-afte.patch --]
[-- Type: text/x-patch, Size: 3269 bytes --]
From: Rohinthan <rokinthanp03@gmail.com>
Subject: [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check
Date: Thu, 10 Sep 2026 17:55:00 +0530
In hackrf_probe(), v4l2_ctrl_auto_cluster() is called immediately after
allocating the auto and manual bandwidth controls for both the receiver
and transmitter.
If allocating the master control (dev->rx_bandwidth_auto or
dev->tx_bandwidth_auto) fails, e.g. due to memory allocation failure,
the pointer is NULL and the error is recorded in the control handler.
Calling v4l2_ctrl_auto_cluster() with a NULL master control causes
v4l2_ctrl_cluster() to trigger a WARNING:
ncontrols == 0 || controls[0] == NULL
WARNING: drivers/media/v4l2-core/v4l2-ctrls-core.c:2525 at v4l2_ctrl_cluster
Fix this by moving the v4l2_ctrl_auto_cluster() invocations down after
checking dev->rx_ctrl_handler.error and dev->tx_ctrl_handler.error.
If control allocation fails, probe cleanly aborts with an error without
attempting to cluster NULL controls.
Fixes: 81774395a8d9 ("[media] hackrf: new driver")
Reported-by: syzbot+cf896de36144391bcde1@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=cf896de36144391bcde1
Signed-off-by: Rohinthan <rokinthanp03@gmail.com>
---
v1 -> v2: Fix email indentation and whitespace corruption from initial submission.
drivers/media/usb/hackrf/hackrf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
--- a/drivers/media/usb/hackrf/hackrf.c
+++ b/drivers/media/usb/hackrf/hackrf.c
@@ -1427,7 +1427,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->rx_bandwidth = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
dev->rx_rf_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
&hackrf_ctrl_ops_rx, V4L2_CID_RF_TUNER_RF_GAIN, 0, 12, 12, 0);
dev->rx_lna_gain = v4l2_ctrl_new_std(&dev->rx_ctrl_handler,
@@ -1439,6 +1438,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_rx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->rx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->rx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->rx_ctrl_handler);
@@ -1450,7 +1450,6 @@ static int hackrf_probe(struct usb_interface *intf,
dev->tx_bandwidth = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_BANDWIDTH,
1750000, 28000000, 50000, 1750000);
- v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
dev->tx_lna_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
&hackrf_ctrl_ops_tx, V4L2_CID_RF_TUNER_LNA_GAIN, 0, 47, 1, 0);
dev->tx_rf_gain = v4l2_ctrl_new_std(&dev->tx_ctrl_handler,
@@ -1460,6 +1459,7 @@ static int hackrf_probe(struct usb_interface *intf,
dev_err(dev->dev, "Could not initialize controls\n");
goto err_v4l2_ctrl_handler_free_tx;
}
+ v4l2_ctrl_auto_cluster(2, &dev->tx_bandwidth_auto, 0, false);
v4l2_ctrl_grab(dev->tx_rf_gain, !hackrf_enable_rf_gain_ctrl);
v4l2_ctrl_handler_setup(&dev->tx_ctrl_handler);
--
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-11 9:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 14:26 [PATCH v2] media: hackrf: defer v4l2_ctrl_auto_cluster() until after error check Rokinthan p
2026-09-11 9:40 ` Hans Verkuil
2026-09-11 9:42 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2026-09-10 12:34 Rokinthan p
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®