From: "rae l" <crquan@gmail.com>
To: "Paul Clements" <paul.clements@steeleye.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Pavel Machek" <pavel@ucw.cz>,
"Steven Whitehouse" <steve@chygwyn.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable
Date: Thu, 19 Jul 2007 23:55:18 +0800 [thread overview]
Message-ID: <91b13c310707190855h6fee9604pcc86b6712d2c76f8@mail.gmail.com> (raw)
In-Reply-To: <469F7F58.4080709@steeleye.com>
On 7/19/07, Paul Clements <paul.clements@steeleye.com> wrote:
> Could you name "n" as "tmp" (as in the previous code) so that it's clear
> that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name "n" as in the declaration of
list_for_each_entry_safe in the header file <linux/list.h>
I'll resend it a little later.
>
> Thanks,
> Paul
>
--
Denis Cheng
Linux Application Developer
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
next prev parent reply other threads:[~2007-07-19 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 9:34 Denis Cheng
2007-07-19 9:34 ` [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call Denis Cheng
2007-07-19 17:35 ` Paul Clements
2007-07-20 1:46 ` rae l
2007-07-19 15:12 ` [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable Paul Clements
2007-07-19 15:55 ` rae l [this message]
2007-07-19 16:48 ` rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b13c310707190855h6fee9604pcc86b6712d2c76f8@mail.gmail.com \
--to=crquan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.clements@steeleye.com \
--cc=pavel@ucw.cz \
--cc=steve@chygwyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome