Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

["rae l" <crquan@gmail.com>]

On 7/19/07, rae l <crquan@gmail.com> wrote:
> On 7/19/07, Paul Clements <paul.clements@steeleye.com> wrote:
> > Could you name "n" as "tmp" (as in the previous code) so that it's clear
> > that's only a temporary variable. Other than that, this looks good.
> Sure. I just use the name "n" as in the declaration of
> list_for_each_entry_safe in the header file <linux/list.h>
> I'll resend it a little later.

Signed-off-by: Denis Cheng <crquan@gmail.com>
---
 drivers/block/nbd.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index c129510..86639c0 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -237,8 +237,7 @@ error_out:

 static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
 {
-	struct request *req;
-	struct list_head *tmp;
+	struct request *req, *tmp;
 	struct request *xreq;
 	int err;

@@ -249,8 +248,7 @@ static struct request *nbd_find_request(struct
nbd_device *lo, char *handle)
 		goto out;

 	spin_lock(&lo->queue_lock);
-	list_for_each(tmp, &lo->queue_head) {
-		req = list_entry(tmp, struct request, queuelist);
+	list_for_each_entry_safe(req, tmp, &lo->queue_head, queuelist) {
 		if (req != xreq)
 			continue;
 		list_del_init(&req->queuelist);

-- 
Denis Cheng
Linux Application Developer

"One of my most productive days was throwing away 1000 lines of code."
 - Ken Thompson.