From: Joe Perches <joe@perches.com>
To: Nicolai Fischer <nicolai.fischer@fau.de>, linux-kernel@vger.kernel.org
Cc: apw@canonical.com, johannes.czekay@fau.de, linux-kernel@i4.cs.fau.de
Subject: Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing
Date: Thu, 10 Dec 2020 14:20:12 -0800 [thread overview]
Message-ID: <91b4b2f3591e6e8ce2d61daae31f2218d1a12b9e.camel@perches.com> (raw)
In-Reply-To: <d97d491e-10fe-5c2e-ebdd-45f437afd257@fau.de>
On Wed, 2020-12-09 at 15:24 +0100, Nicolai Fischer wrote:
> We understand that checkpatch may not be the ideal place for all of these checks.
So please work on an ideal thing.
> However the current implementation has some problems we would like to fix.
> Would you be interested in a patch series addressing just the check for the number of lines?
> Specifically:
> 1)
> >
> > >
> > > I believe all the '---help---' lines have been converted to just 'help'
> > > so the '(?:---)?' bits here could be removed.
> >
> > Yes.
> >
> 2) add string, hex and int types to the $is_start regex
sure
> 3) improve the help message to include the number of present and expected lines
no. The concept of a required paragraph is still dubious.
> 4) Warn if help text is not followed by a blank line or endif
How often is it now not followed by a blank line or endif?
prev parent reply other threads:[~2020-12-10 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a07d684c-37ea-b589-c4b1-489e88b5caa5@fau.de>
2020-12-08 17:18 ` Nicolai Fischer
2020-12-08 18:58 ` Joe Perches
2020-12-09 14:24 ` Nicolai Fischer
2020-12-10 22:20 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b4b2f3591e6e8ce2d61daae31f2218d1a12b9e.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=johannes.czekay@fau.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolai.fischer@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®