mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, Gao Xiang <xiang@kernel.org>
Cc: Chao Yu <chao@kernel.org>, Yue Hu <huyue2@coolpad.com>,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	Sandeep Dhavale <dhavale@google.com>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan_folio()
Date: Sat, 13 Jul 2024 12:44:04 +0800	[thread overview]
Message-ID: <91b66d05-eeff-4d84-a726-cee087bce967@linux.alibaba.com> (raw)
In-Reply-To: <f78ab50e-ed6d-4275-8dd4-a4159fa565a2@stanley.mountain>



On 2024/7/13 09:04, Dan Carpenter wrote:
> Smatch complains that:
> 
>      fs/erofs/zdata.c:1047 z_erofs_scan_folio()
>      error: uninitialized symbol 'err'.
> 
> The issue is if we hit this (!(map->m_flags & EROFS_MAP_MAPPED)) {
> condition then "err" isn't set.  It's inside a loop so we would have to
> hit that condition on every iteration.  Initialize "err" to zero to
> solve this.
> 
> Fixes: 5b9654efb604 ("erofs: teach z_erofs_scan_folios() to handle multi-page folios")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Thanks, applied.

Thanks,
Gao Xiang

      reply	other threads:[~2024-07-13  4:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-13  1:04 Dan Carpenter
2024-07-13  4:44 ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b66d05-eeff-4d84-a726-cee087bce967@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=dhavale@google.com \
    --cc=huyue2@coolpad.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®