* [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan_folio()
@ 2024-07-13 1:04 Dan Carpenter
2024-07-13 4:44 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-07-13 1:04 UTC (permalink / raw)
To: Gao Xiang
Cc: Chao Yu, Yue Hu, Jeffle Xu, Sandeep Dhavale, linux-erofs,
linux-kernel, kernel-janitors
Smatch complains that:
fs/erofs/zdata.c:1047 z_erofs_scan_folio()
error: uninitialized symbol 'err'.
The issue is if we hit this (!(map->m_flags & EROFS_MAP_MAPPED)) {
condition then "err" isn't set. It's inside a loop so we would have to
hit that condition on every iteration. Initialize "err" to zero to
solve this.
Fixes: 5b9654efb604 ("erofs: teach z_erofs_scan_folios() to handle multi-page folios")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/erofs/zdata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index aff3cdf114ad..ac5ffd4674e4 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -962,7 +962,7 @@ static int z_erofs_scan_folio(struct z_erofs_decompress_frontend *f,
const unsigned int bs = i_blocksize(inode);
unsigned int end = folio_size(folio), split = 0, cur, pgs;
bool tight, excl;
- int err;
+ int err = 0;
tight = (bs == PAGE_SIZE);
z_erofs_onlinefolio_init(folio);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan_folio()
2024-07-13 1:04 [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan_folio() Dan Carpenter
@ 2024-07-13 4:44 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2024-07-13 4:44 UTC (permalink / raw)
To: Dan Carpenter, Gao Xiang
Cc: Chao Yu, Yue Hu, Jeffle Xu, Sandeep Dhavale, linux-erofs,
linux-kernel, kernel-janitors
On 2024/7/13 09:04, Dan Carpenter wrote:
> Smatch complains that:
>
> fs/erofs/zdata.c:1047 z_erofs_scan_folio()
> error: uninitialized symbol 'err'.
>
> The issue is if we hit this (!(map->m_flags & EROFS_MAP_MAPPED)) {
> condition then "err" isn't set. It's inside a loop so we would have to
> hit that condition on every iteration. Initialize "err" to zero to
> solve this.
>
> Fixes: 5b9654efb604 ("erofs: teach z_erofs_scan_folios() to handle multi-page folios")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Thanks, applied.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-13 4:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-13 1:04 [PATCH] erofs: silence uninitialized variable warning in z_erofs_scan_folio() Dan Carpenter
2024-07-13 4:44 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®