From: Dmitry Kasatkin <dmitry.s.kasatkin@gmail.com>
To: linux-security-module@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com
Subject: [RFC v1 5/5] evm: creates dedicated evm keyring to store public keys
Date: Wed, 8 Jun 2011 12:03:20 +0300 [thread overview]
Message-ID: <91c60b69df5c63fdccb993569c91ba2f2e36bd04.1307522457.git.dmitry.kasatkin@intel.com> (raw)
In-Reply-To: <cover.1307522457.git.dmitry.kasatkin@intel.com>
In-Reply-To: <cover.1307522457.git.dmitry.kasatkin@intel.com>
From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
EVM/IMA might perform lots of signature verification operations.
For that reason performance is very critical. This patch adds
evm_keyring to store public keys used by EVM only.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
---
security/integrity/evm/evm.h | 4 +++-
security/integrity/evm/evm_main.c | 18 ++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/security/integrity/evm/evm.h b/security/integrity/evm/evm.h
index 9e1bcba..4f4ba20 100644
--- a/security/integrity/evm/evm.h
+++ b/security/integrity/evm/evm.h
@@ -32,6 +32,8 @@ extern struct crypto_shash *hash_tfm;
/* List of EVM protected security xattrs */
extern char *evm_config_xattrnames[];
+extern struct key *evm_keyring;
+
extern int evm_init_key(void);
extern int evm_update_evmxattr(struct dentry *dentry,
const char *req_xattr_name,
@@ -53,7 +55,7 @@ extern void evm_cleanup_secfs(void);
static inline int evm_sign_verify(const char *sig, int siglen,
const char *digest, int digestlen)
{
- return ksign_verify(NULL, sig, siglen, digest, digestlen);
+ return ksign_verify(evm_keyring, sig, siglen, digest, digestlen);
}
#else
diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
index 65518fb..96794a0 100644
--- a/security/integrity/evm/evm_main.c
+++ b/security/integrity/evm/evm_main.c
@@ -20,6 +20,7 @@
#include <linux/integrity.h>
#include <linux/evm.h>
#include <crypto/hash.h>
+#include <linux/init_task.h>
#include "evm.h"
int evm_initialized;
@@ -38,6 +39,8 @@ char *evm_config_xattrnames[] = {
NULL
};
+struct key *evm_keyring;
+
static int evm_fixmode;
static int __init evm_set_fixmode(char *str)
{
@@ -382,18 +385,33 @@ static int __init init_evm(void)
{
int error;
+#ifdef CONFIG_EVM_DIGSIG
+ evm_keyring = keyring_alloc("_evm", 0, 0, &init_cred,
+ KEY_ALLOC_NOT_IN_QUOTA, NULL);
+ if (IS_ERR(evm_keyring))
+ return PTR_ERR(evm_keyring);
+#endif
+
error = evm_init_secfs();
if (error < 0) {
printk(KERN_INFO "EVM: Error registering secfs\n");
goto err;
}
+
+ return 0;
err:
+#ifdef CONFIG_EVM_DIGSIG
+ key_put(evm_keyring);
+#endif
return error;
}
static void __exit cleanup_evm(void)
{
evm_cleanup_secfs();
+#ifdef CONFIG_EVM_DIGSIG
+ key_put(evm_keyring);
+#endif
if (hmac_tfm)
crypto_free_shash(hmac_tfm);
if (hash_tfm)
--
1.7.4.1
prev parent reply other threads:[~2011-06-08 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 9:03 [RFC v1 0/5] evm: digital signature extension Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 1/5] crypto: GnuPG based MPI lib Dmitry Kasatkin
2011-06-15 23:38 ` James Morris
2011-06-16 11:42 ` Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 2/5] crypto: ksign - digital signature verification support Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 3/5] evm: digital signature support Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 4/5] ksign: provides keyring to search in for the key Dmitry Kasatkin
2011-06-08 9:03 ` Dmitry Kasatkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91c60b69df5c63fdccb993569c91ba2f2e36bd04.1307522457.git.dmitry.kasatkin@intel.com \
--to=dmitry.s.kasatkin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®