From: Dmitry Kasatkin <dmitry.s.kasatkin@gmail.com>
To: linux-security-module@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com
Subject: [RFC v1 4/5] ksign: provides keyring to search in for the key
Date: Wed, 8 Jun 2011 12:03:19 +0300 [thread overview]
Message-ID: <a428503ea101e27ddc039bffe9f0a2b8bbf68ef8.1307522457.git.dmitry.kasatkin@intel.com> (raw)
In-Reply-To: <cover.1307522457.git.dmitry.kasatkin@intel.com>
In-Reply-To: <cover.1307522457.git.dmitry.kasatkin@intel.com>
From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Allows to specify keyring to search in for the key. Later patches
will use special keyrings to store EVM and IMA public keys.
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
---
crypto/ksign.c | 17 ++++++++++++++---
include/linux/crypto/ksign.h | 4 ++--
security/integrity/evm/evm.h | 2 +-
3 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/crypto/ksign.c b/crypto/ksign.c
index 60ccfc9..ed355b7 100644
--- a/crypto/ksign.c
+++ b/crypto/ksign.c
@@ -183,7 +183,7 @@ err1:
/*
* Signature verification with public key
*/
-int ksign_verify(const char *sig, int siglen,
+int ksign_verify(struct key *keyring, const char *sig, int siglen,
const char *digest, int digestlen)
{
int err = -ENOMEM;
@@ -201,10 +201,21 @@ int ksign_verify(const char *sig, int siglen,
sprintf(name, "%llX", __be64_to_cpup((uint64_t *)sh->keyid));
- key = request_key(&key_type_user, name, NULL);
+ if (keyring) {
+ /* search in specific keyring */
+ key_ref_t kref;
+ kref = keyring_search(make_key_ref(keyring, 1UL),
+ &key_type_user, name);
+ if (IS_ERR(kref))
+ key = ERR_PTR(PTR_ERR(kref));
+ else
+ key = key_ref_to_ptr(kref);
+ } else {
+ key = request_key(&key_type_user, name, NULL);
+ }
if (IS_ERR(key)) {
pr_err("key not found, id: %s\n", name);
- return -ENOENT;
+ return PTR_ERR(key);
}
desc = kzalloc(sizeof(*desc) + crypto_shash_descsize(shash),
diff --git a/include/linux/crypto/ksign.h b/include/linux/crypto/ksign.h
index f1e47cb..ba23b2a 100644
--- a/include/linux/crypto/ksign.h
+++ b/include/linux/crypto/ksign.h
@@ -32,12 +32,12 @@ struct signature_hdr {
#ifdef CONFIG_CRYPTO_KSIGN
-int ksign_verify(const char *sig, int siglen,
+int ksign_verify(struct key *keyring, const char *sig, int siglen,
const char *digest, int digestlen);
#else
-static inline int ksign_verify(const char *sig, int siglen,
+static inline int ksign_verify(struct key *keyring, const char *sig, int siglen,
const char *digest, int digestlen)
{
return -EOPNOTSUPP;
diff --git a/security/integrity/evm/evm.h b/security/integrity/evm/evm.h
index 6d297a1..9e1bcba 100644
--- a/security/integrity/evm/evm.h
+++ b/security/integrity/evm/evm.h
@@ -53,7 +53,7 @@ extern void evm_cleanup_secfs(void);
static inline int evm_sign_verify(const char *sig, int siglen,
const char *digest, int digestlen)
{
- return ksign_verify(sig, siglen, digest, digestlen);
+ return ksign_verify(NULL, sig, siglen, digest, digestlen);
}
#else
--
1.7.4.1
next prev parent reply other threads:[~2011-06-08 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 9:03 [RFC v1 0/5] evm: digital signature extension Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 1/5] crypto: GnuPG based MPI lib Dmitry Kasatkin
2011-06-15 23:38 ` James Morris
2011-06-16 11:42 ` Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 2/5] crypto: ksign - digital signature verification support Dmitry Kasatkin
2011-06-08 9:03 ` [RFC v1 3/5] evm: digital signature support Dmitry Kasatkin
2011-06-08 9:03 ` Dmitry Kasatkin [this message]
2011-06-08 9:03 ` [RFC v1 5/5] evm: creates dedicated evm keyring to store public keys Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a428503ea101e27ddc039bffe9f0a2b8bbf68ef8.1307522457.git.dmitry.kasatkin@intel.com \
--to=dmitry.s.kasatkin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®