* [PATCH] media: iris: add cyclic intra refresh on AR50LT encoder
@ 2026-10-23 3:16 Gourav Kumar
2026-10-26 18:15 ` Vikash Garodia
0 siblings, 1 reply; 2+ messages in thread
From: Gourav Kumar @ 2026-10-23 3:16 UTC (permalink / raw)
To: Vikash Garodia, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel, Gourav Kumar
The Gen2 AR50LT encoder capability table advertises only the RANDOM
intra refresh type, so V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE
exposes a single menu entry and userspace cannot select CYCLIC.
Advertise CYCLIC alongside RANDOM in the AR50LT encoder capabilities so
that userspace can choose between the two intra refresh types. RANDOM
remains the default, so existing behaviour is unchanged.
Signed-off-by: Gourav Kumar <gourav.kumar@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
index 79bbd06ef8d2..794c36d222d3 100644
--- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
@@ -2600,8 +2600,9 @@ static const struct platform_inst_fw_cap inst_fw_cap_gen2_ar50lt_enc[] = {
{
.cap_id = IR_TYPE,
.min = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM,
- .max = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM,
- .step_or_mask = BIT(V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM),
+ .max = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_CYCLIC,
+ .step_or_mask = BIT(V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM) |
+ BIT(V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_CYCLIC),
.value = V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE_RANDOM,
.flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
},
---
base-commit: bd1ecbb61afefc6a8b876ccbc31e9228b44e9eab
change-id: 20261023-iris-ar50lt-ir-cyclic-ec24f4150077
Best regards,
--
Gourav Kumar <gourav.kumar@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: iris: add cyclic intra refresh on AR50LT encoder
2026-10-23 3:16 [PATCH] media: iris: add cyclic intra refresh on AR50LT encoder Gourav Kumar
@ 2026-10-26 18:15 ` Vikash Garodia
0 siblings, 0 replies; 2+ messages in thread
From: Vikash Garodia @ 2026-10-26 18:15 UTC (permalink / raw)
To: Gourav Kumar, Dikshita Agarwal, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 10/23/2026 8:46 AM, Gourav Kumar wrote:
> The Gen2 AR50LT encoder capability table advertises only the RANDOM
> intra refresh type, so V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE
> exposes a single menu entry and userspace cannot select CYCLIC.
>
> Advertise CYCLIC alongside RANDOM in the AR50LT encoder capabilities so
> that userspace can choose between the two intra refresh types. RANDOM
> remains the default, so existing behaviour is unchanged.
>
> Signed-off-by: Gourav Kumar<gourav.kumar@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-26 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-23 3:16 [PATCH] media: iris: add cyclic intra refresh on AR50LT encoder Gourav Kumar
2026-10-26 18:15 ` Vikash Garodia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®