From: Andrew Lunn <andrew@lunn.ch>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Daniel Golle <daniel@makrotopia.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c
Date: Fri, 28 Jun 2024 16:09:01 +0200 [thread overview]
Message-ID: <92078d5d-3b10-4651-a42b-4b2ffd23daca@lunn.ch> (raw)
In-Reply-To: <CAMRc=Mcftb9MRAP50ZNMfQpsjLzc-=OKvxo5Xkeqdgs-rZFNug@mail.gmail.com>
> Not sure what to do, should I still be adding a new mode here or is it
> fine to just explain in the commit message that this really is
> "2500Base-X-sans-in-band-signalling" and keep the code as is? Or maybe
> some quirk disallowing `managed = "in-band-status"`?
Yes, please do make it clear in the commit message. It is good to have
a full commit message explaining all the messy details to help the
next person who needs to modify this code, or has the same issue with
another vendor specific glue driver for stmmac, etc.
Andrew
prev parent reply other threads:[~2024-06-28 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 11:30 [PATCH v2 net-next 0/3] net: phy: aquantia: enable " Bartosz Golaszewski
2024-06-27 11:30 ` [PATCH v2 net-next 1/3] net: phy: aquantia: rename and export aqr107_wait_reset_complete() Bartosz Golaszewski
2024-06-27 16:20 ` Andrew Lunn
2024-06-27 11:30 ` [PATCH v2 net-next 2/3] net: phy: aquantia: wait for FW reset before checking the vendor ID Bartosz Golaszewski
2024-06-27 16:21 ` Andrew Lunn
2024-06-27 11:30 ` [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c Bartosz Golaszewski
2024-06-27 12:09 ` Russell King (Oracle)
2024-06-27 12:18 ` Bartosz Golaszewski
2024-06-27 16:22 ` Andrew Lunn
2024-06-27 16:48 ` Bartosz Golaszewski
2024-06-27 22:42 ` Daniel Golle
2024-06-28 0:18 ` Andrew Lunn
2024-06-28 1:11 ` Daniel Golle
2024-06-28 12:11 ` Bartosz Golaszewski
2024-06-28 14:09 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92078d5d-3b10-4651-a42b-4b2ffd23daca@lunn.ch \
--to=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®