mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: luka.gejak@linux.dev, Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>,
	Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH 19/19] wifi: rtw88: advertise the correct receive capabilities on RTL8723BS
Date: Sat, 25 Jul 2026 01:29:05 +0300	[thread overview]
Message-ID: <92272d90-a549-437d-886e-308807418485@gmail.com> (raw)
In-Reply-To: <20260724183330.197283-1-luka.gejak@linux.dev>

On 24/07/2026 21:33, luka.gejak@linux.dev wrote:
> From: Luka Gejak <luka.gejak@linux.dev>
> 
> This chip has neither a firmware feature report nor an efuse hardware
> capability parser, so the capability struct is left at zero. A zero
> stream count builds an HT capability with no usable RX MCS rates, and
> APs drop the station immediately after an otherwise successful
> association. Fill in the stream and antenna counts from the RF path
> count, and advertise the 20 and 40 MHz support the chip has.
> 
> RTL8723BS also leaves BIT_APP_FCS clear, so received frames do not carry
> the FCS. Advertising RX_INCLUDES_FCS would make mac80211 trim four bytes
> of real frame data and corrupt the trailing element of beacons and probe
> responses, so leave it unset for this chip.
> 
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
> ---
>  drivers/net/wireless/realtek/rtw88/main.c | 61 +++++++++++++++--------
>  1 file changed, 40 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> index 63d1fb4bc87e..e2f0fd367beb 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -126,6 +126,25 @@ static void rtw_power_on_8723bs_sdio_rfk(struct rtw_dev *rtwdev)
>  	rtwdev->initial_rfk_done = true;
>  }
>  
> +static bool rtw8723bs_station_media_status(struct rtw_dev *rtwdev,
> +					   struct ieee80211_sta *sta,
> +					   struct ieee80211_vif *vif)
> +{
> +	return rtw_is_8723bs(rtwdev) &&
> +	       vif->type == NL80211_IFTYPE_STATION && !sta->tdls;
> +}
> +
> +/* 8723BS SDIO: defer the connect MEDIA_STATUS_RPT until the STA is actually
> + * associated (the vendor firmware sends it at assoc completion, not sta-add).
> + */
> +static bool rtw8723bs_defer_sta_media_status(struct rtw_dev *rtwdev,
> +					     struct ieee80211_sta *sta,
> +					     struct ieee80211_vif *vif)
> +{
> +	return rtw8723bs_station_media_status(rtwdev, sta, vif) &&
> +	       !vif->cfg.assoc;
> +}
> +
>  static struct ieee80211_channel rtw_channeltable_2g[] = {
>  	{.center_freq = 2412, .hw_value = 1,},
>  	{.center_freq = 2417, .hw_value = 2,},
> @@ -304,25 +323,6 @@ static void rtw_sw_beacon_loss_check(struct rtw_dev *rtwdev,
>  /* process TX/RX statistics periodically for hardware,
>   * the information helps hardware to enhance performance
>   */
> -static bool rtw8723bs_station_media_status(struct rtw_dev *rtwdev,
> -					   struct ieee80211_sta *sta,
> -					   struct ieee80211_vif *vif)
> -{
> -	return rtw_is_8723bs(rtwdev) &&
> -	       vif->type == NL80211_IFTYPE_STATION && !sta->tdls;
> -}
> -
> -/* 8723BS SDIO: defer the connect MEDIA_STATUS_RPT until the STA is actually
> - * associated (the vendor firmware sends it at assoc completion, not sta-add).
> - */
> -static bool rtw8723bs_defer_sta_media_status(struct rtw_dev *rtwdev,
> -					     struct ieee80211_sta *sta,
> -					     struct ieee80211_vif *vif)
> -{
> -	return rtw8723bs_station_media_status(rtwdev, sta, vif) &&
> -	       !vif->cfg.assoc;
> -}
> -
>  static void rtw_watch_dog_work(struct work_struct *work)
>  {
>  	struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
> @@ -401,6 +401,7 @@ static void rtw_watch_dog_work(struct work_struct *work)
>  	 * get that vif and check if device is having traffic more than the
>  	 * threshold.
>  	 */
> +
>  	/* On 8723BS SDIO the firmware's per-packet wake latency out of LPS
>  	 * throttles bursty traffic hard. The stock check enters LPS after a
>  	 * single quiet 2s window, which a normal bursty session hits
> @@ -2122,8 +2123,21 @@ static int rtw_dump_hw_feature(struct rtw_dev *rtwdev)
>  	u8 bw;
>  	int i;
>  
> -	if (!rtwdev->chip->hw_feature_report)
> +	if (!rtwdev->chip->hw_feature_report) {
> +		/* 8723BS has neither a firmware feature report nor an efuse hw_cap
> +		 * parser, so hw_cap is otherwise left at zero. A zero stream count
> +		 * produces an HT capability with no usable RX MCS rates, which makes
> +		 * APs drop the station immediately after a successful association.
> +		 * Other report-less chips fill hw_cap in when parsing the efuse.

You can do that too instead of adding special code here. You can
make your own rtw8723b_read_efuse() which calls rtw8723x_read_efuse()
and also fills hw_cap.

> +		 */
> +		if (rtw_is_8723bs(rtwdev)) {
> +			efuse->hw_cap.nss = rtwdev->hal.rf_path_num ? : 1;
> +			efuse->hw_cap.ant_num = rtwdev->hal.rf_path_num ? : 1;
> +			efuse->hw_cap.bw = BIT(RTW_CHANNEL_WIDTH_20) |
> +					   BIT(RTW_CHANNEL_WIDTH_40);
> +		}
>  		return 0;
> +	}
>  
>  	id = rtw_read8(rtwdev, REG_C2HEVT);
>  	if (id != C2H_HW_FEATURE_REPORT) {
> @@ -2429,7 +2443,12 @@ int rtw_register_hw(struct rtw_dev *rtwdev, struct ieee80211_hw *hw)
>  	hw->vif_data_size = sizeof(struct rtw_vif);
>  
>  	ieee80211_hw_set(hw, SIGNAL_DBM);
> -	ieee80211_hw_set(hw, RX_INCLUDES_FCS);
> +	/* RTL8723BS keeps BIT_APP_FCS clear, so received frames do not contain
> +	 * the FCS. Advertising RX_INCLUDES_FCS would make mac80211 trim four
> +	 * bytes of frame data and corrupt the tail IE in beacons/probe responses.
> +	 */

The driver is supposed to set that bit. The default value of
rtwdev->hal.rcr includes it. I think that should work for this
chip too.

> +	if (!rtw_is_8723bs(rtwdev))
> +		ieee80211_hw_set(hw, RX_INCLUDES_FCS);
>  	ieee80211_hw_set(hw, AMPDU_AGGREGATION);
>  	ieee80211_hw_set(hw, MFP_CAPABLE);
>  	ieee80211_hw_set(hw, REPORTS_TX_ACK_STATUS);


  reply	other threads:[~2026-07-24 22:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 18:18 [PATCH 00/19] wifi: rtw88: preparations for RTL8723B/RTL8723BS luka.gejak
2026-07-24 18:18 ` [PATCH 01/19] wifi: rtw88: add the RTL8723B chip type and SDIO helper luka.gejak
2026-07-24 18:18 ` [PATCH 02/19] wifi: rtw88: rx: mark zero length packets on RTL8723B luka.gejak
2026-07-24 22:34   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:18 ` [PATCH 03/19] wifi: rtw88: tx: extend the TX report purge timeout to RTL8723BS luka.gejak
2026-07-24 18:18 ` [PATCH 04/19] wifi: rtw88: fw: handle the RTL8723BS management TX reports luka.gejak
2026-07-24 22:53   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:18 ` [PATCH 05/19] wifi: rtw88: fw: send rate adaptation and RSSI info in the vendor layout luka.gejak
2026-07-24 23:46   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:18 ` [PATCH 06/19] wifi: rtw88: fw: send the media status report " luka.gejak
2026-07-24 23:52   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:18 ` [PATCH 07/19] wifi: rtw88: fw: add the vendor firmware commands used by RTL8723BS luka.gejak
2026-07-25 10:17   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:18 ` [PATCH 08/19] wifi: rtw88: fw: fix the reserved page upload on RTL8723BS luka.gejak
2026-07-24 18:18 ` [PATCH 09/19] wifi: rtw88: coex: add the RTL8723BS scan antenna workaround luka.gejak
2026-07-24 18:32 ` [PATCH 10/19] wifi: rtw88: coex: reassert the antenna path when associating luka.gejak
2026-07-24 18:32 ` [PATCH 11/19] wifi: rtw88: sdio: track free TX pages and OQT credits for RTL8723BS luka.gejak
2026-07-24 18:32 ` [PATCH 12/19] wifi: rtw88: sdio: handle the RTL8723BS management TX path luka.gejak
2026-07-25 11:08   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:32 ` [PATCH 13/19] wifi: rtw88: sdio: set up RX aggregation and interrupts for RTL8723BS luka.gejak
2026-07-25 11:25   ` Bitterblue Smith
2026-07-26  1:35     ` Ping-Ke Shih
2026-07-26  6:17       ` Luka Gejak
2026-07-27  2:31         ` Ping-Ke Shih
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:32 ` [PATCH 14/19] wifi: rtw88: sdio: add TX back-pressure and retry on page starvation luka.gejak
2026-07-24 18:32 ` [PATCH 15/19] wifi: rtw88: record beacons from the target BSSID before authenticating luka.gejak
2026-07-24 18:32 ` [PATCH 16/19] wifi: rtw88: run the RTL8723BS association register sequence luka.gejak
2026-07-24 18:33 ` [PATCH 17/19] wifi: rtw88: calibrate and tune the PHY for RTL8723BS luka.gejak
2026-07-24 21:05   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:33 ` [PATCH 18/19] wifi: rtw88: match the RTL8723BS firmware connect and power save behaviour luka.gejak
2026-07-24 22:10   ` Bitterblue Smith
2026-07-30  6:08     ` luka.gejak
2026-07-24 18:33 ` [PATCH 19/19] wifi: rtw88: advertise the correct receive capabilities on RTL8723BS luka.gejak
2026-07-24 22:29   ` Bitterblue Smith [this message]
2026-07-30  6:08     ` luka.gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92272d90-a549-437d-886e-308807418485@gmail.com \
    --to=rtl8821cerfe2@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=pbrobinson@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®