From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Yue Haibing <yuehaibing@huawei.com>,
davem@davemloft.net, jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next] igc: Make igc_write_rss_indir_tbl static
Date: Wed, 20 Mar 2019 09:07:08 +0200 [thread overview]
Message-ID: <92371ea1-e9d7-e0b1-1c7a-a374f3c68681@intel.com> (raw)
In-Reply-To: <20190319145507.22388-1-yuehaibing@huawei.com>
On 3/19/2019 16:55, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6:
> warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index eff37a6..5442394 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
> return 0;
> }
>
> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> {
> struct igc_hw *hw = &adapter->hw;
> u32 reg = IGC_RETA(0);
>
The 'igc_write_rss_indir_tbl' method is declared in igc.h and used in
igc_main.c
Please, refer to latest Jeff next-queue, there is latest patches used
these methods.
next prev parent reply other threads:[~2019-03-20 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:55 Yue Haibing
2019-03-20 7:07 ` Neftin, Sasha [this message]
2019-03-20 7:52 ` [Intel-wired-lan] " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92371ea1-e9d7-e0b1-1c7a-a374f3c68681@intel.com \
--to=sasha.neftin@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome