* [PATCH net-next] igc: Make igc_write_rss_indir_tbl static
@ 2019-03-19 14:55 Yue Haibing
2019-03-20 7:07 ` [Intel-wired-lan] " Neftin, Sasha
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2019-03-19 14:55 UTC (permalink / raw)
To: davem, jeffrey.t.kirsher
Cc: linux-kernel, netdev, intel-wired-lan, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6:
warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index eff37a6..5442394 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
return 0;
}
-void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
+static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
{
struct igc_hw *hw = &adapter->hw;
u32 reg = IGC_RETA(0);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] igc: Make igc_write_rss_indir_tbl static
2019-03-19 14:55 [PATCH net-next] igc: Make igc_write_rss_indir_tbl static Yue Haibing
@ 2019-03-20 7:07 ` Neftin, Sasha
2019-03-20 7:52 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Neftin, Sasha @ 2019-03-20 7:07 UTC (permalink / raw)
To: Yue Haibing, davem, jeffrey.t.kirsher
Cc: netdev, intel-wired-lan, linux-kernel
On 3/19/2019 16:55, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6:
> warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index eff37a6..5442394 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
> return 0;
> }
>
> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> {
> struct igc_hw *hw = &adapter->hw;
> u32 reg = IGC_RETA(0);
>
The 'igc_write_rss_indir_tbl' method is declared in igc.h and used in
igc_main.c
Please, refer to latest Jeff next-queue, there is latest patches used
these methods.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-wired-lan] [PATCH net-next] igc: Make igc_write_rss_indir_tbl static
2019-03-20 7:07 ` [Intel-wired-lan] " Neftin, Sasha
@ 2019-03-20 7:52 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-03-20 7:52 UTC (permalink / raw)
To: Neftin, Sasha, davem, jeffrey.t.kirsher
Cc: netdev, intel-wired-lan, linux-kernel
On 2019/3/20 15:07, Neftin, Sasha wrote:
> On 3/19/2019 16:55, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warning:
>>
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6:
>> warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index eff37a6..5442394 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
>> return 0;
>> }
>> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>> {
>> struct igc_hw *hw = &adapter->hw;
>> u32 reg = IGC_RETA(0);
>>
> The 'igc_write_rss_indir_tbl' method is declared in igc.h and used in igc_main.c
> Please, refer to latest Jeff next-queue, there is latest patches used these methods.
Well, I did not refer to Jeff's tree. So this patch can be dropped.
Thanks!
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:55 [PATCH net-next] igc: Make igc_write_rss_indir_tbl static Yue Haibing
2019-03-20 7:07 ` [Intel-wired-lan] " Neftin, Sasha
2019-03-20 7:52 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome