Re: [PATCH v3 1/2] drm/panel: simple: Add Waveshare 13.3" panel support

[Marek Vasut <marek.vasut@mailbox.org>]

On 1/19/26 4:56 PM, Geert Uytterhoeven wrote:

Hello Geert,

>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -4998,6 +4998,33 @@ static const struct panel_desc vl050_8048nt_c01 = {
>>          .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
>>   };
>>
>> +static const struct drm_display_mode waveshare_133inch_mode = {
>> +       .clock = 148500,
>> +       .hdisplay = 1920,
>> +       .hsync_start = 1920 + 88,
>> +       .hsync_end = 1920 + 88 + 44,
>> +       .htotal = 1920 + 88 + 44 + 148,
>> +       .vdisplay = 1080,
>> +       .vsync_start = 1080 + 4,
>> +       .vsync_end = 1080 + 4 + 5,
>> +       .vtotal = 1080 + 4 + 5 + 36,
>> +       .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
>> +};
> 
> That looks like the plain standard 60Hz Full HD mode.
> Is there really no other copy of that structure available in the kernel?
> 
> auo_t215hvn01_mode is almost the same, except for .clock and .flags.
> drivers/video/fbdev/core/modedb.c has the same mode, but in a different
> structure.

The panel-simple.c is full of similar-ish panel timings . The timings 
above are adapted from the waveshare DTO for this panel. What else would 
you suggest I do/use for this device ?