Re: [PATCH v3 1/2] drm/panel: simple: Add Waveshare 13.3" panel support

[Marek Vasut <marek.vasut@mailbox.org>]

On 2/16/26 5:01 PM, Neil Armstrong wrote:
> On 1/17/26 01:49, Marek Vasut wrote:
>> Add WaveShare 13.3inch 1920x1080 DSI Capacitive Touch Display support.
>>
>> While the panel is described as DPI panel, it is part of a larger unit
>> in non-removable metal casing, so the actual internal configuration is
>> not known. The panel is attached to "waveshare,dsi2dpi" bridge via DT.
>> It is likely that internally, this panel is an LVDS panel, connected to
>> ICN6211 DSI-to-DPI bridge and then another unknown DPI-to-LVDS bridge.
>>
>> Current device link is at https://www.waveshare.com/13.3inch-dsi-lcd.htm
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Jessica Zhang <jesszhan0024@gmail.com>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: Simona Vetter <simona@ffwll.ch>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: devicetree@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V3: New patch. Note that the compatible string is already part of
>>      Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> ---
>>   drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/ 
>> panel/panel-simple.c
>> index 91ab280869bac..40a73c32b0b17 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -4998,6 +4998,33 @@ static const struct panel_desc vl050_8048nt_c01 
>> = {
>>       .bus_flags = DRM_BUS_FLAG_DE_HIGH | 
>> DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
>>   };
>> +static const struct drm_display_mode waveshare_133inch_mode = {
>> +    .clock = 148500,
>> +    .hdisplay = 1920,
>> +    .hsync_start = 1920 + 88,
>> +    .hsync_end = 1920 + 88 + 44,
>> +    .htotal = 1920 + 88 + 44 + 148,
>> +    .vdisplay = 1080,
>> +    .vsync_start = 1080 + 4,
>> +    .vsync_end = 1080 + 4 + 5,
>> +    .vtotal = 1080 + 4 + 5 + 36,
>> +    .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
>> +};
>> +
>> +static const struct panel_desc waveshare_133inch = {
>> +    .modes = &waveshare_133inch_mode,
>> +    .num_modes = 1,
>> +    .bpc = 8,
>> +    .size = {
>> +        .width = 293,
>> +        .height = 163,
>> +    },
>> +    .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>> +    .connector_type = DRM_MODE_CONNECTOR_DPI,
>> +    .bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE |
>> +             DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE,
>> +};
>> +
>>   static const struct drm_display_mode winstar_wf35ltiacd_mode = {
>>       .clock = 6410,
>>       .hdisplay = 320,
>> @@ -5598,6 +5625,9 @@ static const struct of_device_id 
>> platform_of_match[] = {
>>       }, {
>>           .compatible = "vxt,vl050-8048nt-c01",
>>           .data = &vl050_8048nt_c01,
>> +    }, {
>> +        .compatible = "waveshare,13.3inch-panel",
>> +        .data = &waveshare_133inch,
>>       }, {
>>           .compatible = "winstar,wf35ltiacd",
>>           .data = &winstar_wf35ltiacd,
> 
> LGTM
> 
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Would it be OK to apply this now ? Thank you