mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	alsa-devel@alsa-project.org,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Hui Wang <hui.wang@canonical.com>,
	vkoul@kernel.org, srinivas.kandagatla@linaro.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	jank@cadence.com, slawomir.blauciak@intel.com,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [PATCH 1/4] regmap: sdw: move to -EOPNOTSUPP
Date: Wed, 26 Aug 2020 10:05:50 -0500	[thread overview]
Message-ID: <927c93bc-9ad8-7e5d-a5ea-d566e5f543df@linux.intel.com> (raw)
In-Reply-To: <s5h8se1u2or.wl-tiwai@suse.de>




>>>> checkpatch is broken.
>>
>>> Heh, I'm not objecting it :)
>>
>>> OTOH, it's also true that ENOTSUPP is no good error code if returned
>>> to user-space.  Unfortunately many codes (including what I wrote) use
>>> this code mistakenly, and they can't be changed any longer...
>>
>> It's also used internally in various places without being returned to
>> userspace, that's what's going on here - the regmap core has some
>> specific checks for -ENOTSUPP.
> 
> Sure, for such an internal usage any code can be used.
> The question is a case like this -- where the return code might be
> carried to outside.  Though, looking through the grep output, all
> callers simply return -EINVAL for any errors, so it doesn't matter
> much for now.

I assumed this change to -EOPNOTSUPP reflected a consensus in 
kernel-land, it's obviously not the case. This patch was supposed to be 
a trivial clean-up...

So to be clear, what is the direction for existing code
a) keep -ENOTSUPP as is?
b) move to -EOPNOTSUPP?

And what is the preference for new code?

  parent reply	other threads:[~2020-08-26 15:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 17:16 [PATCH 0/4] regmap: add SoundWire 1.2 MBQ support Pierre-Louis Bossart
2020-08-25 17:16 ` [PATCH 1/4] regmap: sdw: move to -EOPNOTSUPP Pierre-Louis Bossart
2020-08-25 21:48   ` Mark Brown
2020-08-25 22:08     ` Pierre-Louis Bossart
2020-08-26  9:56       ` Mark Brown
2020-08-26 10:09         ` Takashi Iwai
2020-08-26 10:13           ` Mark Brown
2020-08-26 10:22             ` Takashi Iwai
2020-08-26 12:03               ` Vinod Koul
2020-08-26 15:05               ` Pierre-Louis Bossart [this message]
2020-08-26 17:25                 ` Mark Brown
2020-08-26 18:08                   ` Pierre-Louis Bossart
2020-08-25 17:16 ` [PATCH 2/4] regmap: sdw: add required header files Pierre-Louis Bossart
2020-08-25 17:16 ` [PATCH 3/4] soundwire: SDCA: add helper macro to access controls Pierre-Louis Bossart
2020-08-26  1:04   ` Bard liao
2020-08-26  8:55   ` Vinod Koul
2020-08-26 15:00     ` Pierre-Louis Bossart
2020-08-26 16:40       ` Vinod Koul
2020-08-25 17:16 ` [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ Pierre-Louis Bossart
2020-08-26  0:59   ` Bard liao
2020-08-26  9:05   ` Vinod Koul
2020-08-26 16:57     ` Pierre-Louis Bossart
2020-08-28  7:23       ` Vinod Koul
2020-08-28 14:49         ` Pierre-Louis Bossart
2020-08-26 10:16   ` Mark Brown
2020-08-26 14:54     ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=927c93bc-9ad8-7e5d-a5ea-d566e5f543df@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=hui.wang@canonical.com \
    --cc=jank@cadence.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=slawomir.blauciak@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome