From: Jiri Slaby <jirislaby@kernel.org>
To: Qingfang Deng <qingfang.deng@linux.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mitchell Blank Jr <mitch@sfgoth.com>,
Chas Williams <3chas3@gmail.com>, Simon Horman <horms@kernel.org>,
James Chapman <jchapman@katalix.com>, Kees Cook <kees@kernel.org>,
Breno Leitao <leitao@debian.org>, Felix Fietkau <nbd@nbd.name>,
Asim Viladi Oglu Manizada <manizada@pm.me>,
Eric Woudstra <ericwouds@gmail.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH net-next] ppp: pass private data to channel callbacks
Date: Fri, 4 Sep 2026 05:57:09 +0200 [thread overview]
Message-ID: <927e0f8f-a656-45e4-a937-9de88b783073@kernel.org> (raw)
In-Reply-To: <20260904031153.30304-1-qingfang.deng@linux.dev>
Hi,
On 04. 09. 26, 5:11, Qingfang Deng wrote:
> PPP channel callbacks receive struct ppp_channel only to retrieve the
> driver's private pointer. Pass that pointer directly instead.
We had type checking at least. What's the purpose of this patch, actually?
> Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
> ---
> drivers/net/ppp/ppp_async.c | 13 ++++++-------
> drivers/net/ppp/ppp_generic.c | 12 ++++++------
> drivers/net/ppp/ppp_synctty.c | 13 ++++++-------
> drivers/net/ppp/pppoe.c | 8 ++++----
> drivers/net/ppp/pptp.c | 9 ++++-----
> include/linux/ppp_channel.h | 6 +++---
> net/atm/pppoatm.c | 21 ++++++++-------------
> net/l2tp/l2tp_ppp.c | 6 +++---
> 8 files changed, 40 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/net/ppp/ppp_async.c b/drivers/net/ppp/ppp_async.c
> index ea7fe9608ffd..e73b0fce86b9 100644
> --- a/drivers/net/ppp/ppp_async.c
> +++ b/drivers/net/ppp/ppp_async.c
> @@ -91,13 +91,12 @@ MODULE_ALIAS_LDISC(N_PPP);
> * Prototypes.
> */
> static int ppp_async_encode(struct asyncppp *ap);
> -static int ppp_async_send(struct ppp_channel *chan, struct sk_buff *skb);
> +static int ppp_async_send(void *private, struct sk_buff *skb);
thanks,
--
js
suse labs
next prev parent reply other threads:[~2026-09-04 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 3:11 Qingfang Deng
2026-09-04 3:57 ` Jiri Slaby [this message]
2026-09-04 5:39 ` Qingfang Deng
2026-09-04 12:50 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927e0f8f-a656-45e4-a937-9de88b783073@kernel.org \
--to=jirislaby@kernel.org \
--cc=3chas3@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=manizada@pm.me \
--cc=mitch@sfgoth.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®