From: Qingfang Deng <qingfang.deng@linux.dev>
To: Jiri Slaby <jirislaby@kernel.org>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mitchell Blank Jr <mitch@sfgoth.com>,
Chas Williams <3chas3@gmail.com>,
James Chapman <jchapman@katalix.com>,
Simon Horman <horms@kernel.org>, Kees Cook <kees@kernel.org>,
Breno Leitao <leitao@debian.org>, Felix Fietkau <nbd@nbd.name>,
Asim Viladi Oglu Manizada <manizada@pm.me>,
Eric Woudstra <ericwouds@gmail.com>,
linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH net-next] ppp: pass private data to channel callbacks
Date: Fri, 4 Sep 2026 13:39:49 +0800 [thread overview]
Message-ID: <a8497c0e-94be-4cf9-ab64-0402c48c3a88@linux.dev> (raw)
In-Reply-To: <927e0f8f-a656-45e4-a937-9de88b783073@kernel.org>
On 2026/9/4 11:57, Jiri Slaby wrote:
> Hi,
>
> On 04. 09. 26, 5:11, Qingfang Deng wrote:
>> PPP channel callbacks receive struct ppp_channel only to retrieve the
>> driver's private pointer. Pass that pointer directly instead.
>
> We had type checking at least. What's the purpose of this patch, actually?
The goal is to unify the two channel structs and make it owned by the
generic PPP layer.
You can view previous discussions here:
https://lore.kernel.org/netdev/20260430090532.244758-2-qingfang.deng@linux.dev/
Kind regards,
next prev parent reply other threads:[~2026-09-04 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 3:11 Qingfang Deng
2026-09-04 3:57 ` Jiri Slaby
2026-09-04 5:39 ` Qingfang Deng [this message]
2026-09-04 12:50 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8497c0e-94be-4cf9-ab64-0402c48c3a88@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=3chas3@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=manizada@pm.me \
--cc=mitch@sfgoth.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®