From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Anastasov <ja@ssi.bg>, Star Chang <starchang@google.com>
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
linux-kernel@vger.kernel.org, wangroger@google.com
Subject: Re: [PATCH net v4] net: Fix Hole-196 vulnerability by dropping unicast ARP/IP in L2 BMC
Date: Fri, 30 Oct 2026 23:21:59 +0100 [thread overview]
Message-ID: <9291ce4a2dad9a752c84c34a7297dc0dd6b373e0.camel@sipsolutions.net> (raw)
In-Reply-To: <553d89ed-8691-45b6-ac98-0faf00b859cd@ssi.bg>
On Fri, 2026-10-30 at 07:20 +0200, Julian Anastasov wrote:
>
> May be DROP_UNICAST_IN_L2_MULTICAST should drop also
> the GARP packets. Why should the GARP packets to be more
> privileged than the other broadcast requests?
I've been quiet on this ... but in particular for this, why would you
not just use the extra knob we already have?!
johannes
next prev parent reply other threads:[~2026-10-30 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 15:05 [PATCH net v3] " Star Chang
2026-10-27 1:56 ` [PATCH net v4] " Star Chang
2026-10-27 12:16 ` Julian Anastasov
2026-10-28 6:16 ` Star Chang
2026-10-28 15:22 ` Julian Anastasov
2026-10-29 9:02 ` Star Chang
2026-10-30 5:20 ` Julian Anastasov
2026-10-30 22:21 ` Johannes Berg [this message]
2026-10-30 3:07 ` Star Chang
[not found] ` <65cf2338-7bb4-3151-f3b1-ef171bb5723b@ssi.bg>
2026-10-30 6:52 ` Star Chang
2026-10-30 18:46 ` Julian Anastasov
[not found] ` <c2780bb291244cf32c1dbda63f0dcf594d22da30.camel@sipsolutions.net>
2026-11-02 7:05 ` Star Chang
2026-11-02 21:27 ` Julian Anastasov
2026-10-29 16:56 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9291ce4a2dad9a752c84c34a7297dc0dd6b373e0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=starchang@google.com \
--cc=wangroger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®