Re: [PATCH v3 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

Re: [PATCH v3 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

[Hannes Reinecke]

On 2/7/24 23:20, Lee Duncan wrote:
> From: Lee Duncan <lduncan@suse.com>
> 
> This reverts commit 1a1975551943f681772720f639ff42fbaa746212
> 
> This commit causes interrupts to be lost for FCoE devices,
> since it changed sping locks from "bh" to "irqsave".
> 
> Instead, a work queue should be used, and will be addressed
> in a separate patch.
> 
> Fixes: 1a1975551943f681772720f639ff42fbaa746212
Please use the correct fixes tag:

Fixes: 1a1975551943 ("scsi: fcoe: Fix potential deadlock on 
&fip->ctlr_lock")

Otherwise looks good.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich

Re: [PATCH v3 2/2] fnic: move fnic_fnic_flush_tx() to a work queue

[Hannes Reinecke]

On 2/7/24 23:20, Lee Duncan wrote:
> From: Lee Duncan <lduncan@suse.com>
> 
> Rather than call 'fnic_flush_tx()' from interrupt context we should
> be moving it onto a work queue to avoid any locking issues.
> 
> Fixes: 1a1975551943f681772720f639ff42fbaa746212

Same here, please use the correct fixes tag.

> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
>   drivers/scsi/fnic/fnic.h      | 3 ++-
>   drivers/scsi/fnic/fnic_fcs.c  | 5 +++--
>   drivers/scsi/fnic/fnic_main.c | 1 +
>   drivers/scsi/fnic/fnic_scsi.c | 4 ++--
>   4 files changed, 8 insertions(+), 5 deletions(-)
> 
Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich