From: "Adrian McMenamin" <adrianmcmenamin@gmail.com>
To: "Takashi Iwai" <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions
Date: Fri, 6 Jul 2007 11:09:00 +0100 [thread overview]
Message-ID: <92a12cdb0707060309x6fe997nc3112d5545d73ef5@mail.gmail.com> (raw)
In-Reply-To: <s5hvecx4zz5.wl%tiwai@suse.de>
On 06/07/07, Takashi Iwai <tiwai@suse.de> wrote:
> I guess you shoud call del_timer() there at least. Otherwise the
> timer handler (aica_period_elapsed()) might be called even if the
> stream is not really running.
>
Fair enough. I'll fix that and repost later.
> The below is some coding style fixes, BTW. I'm not sure whether
> queue_work() is intended in the block if "if (dma_check == 0)" or
> not.
>
It's just an aberrant indent - I think there was an independent block
there in earlier code, it got removed but the tab stayed :)
next prev parent reply other threads:[~2007-07-06 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 22:07 Adrian McMenamin
2007-07-05 22:23 ` Adrian McMenamin
2007-07-06 9:25 ` [alsa-devel] " Takashi Iwai
2007-07-06 9:46 ` Adrian McMenamin
2007-07-06 9:56 ` Takashi Iwai
2007-07-06 10:09 ` Adrian McMenamin [this message]
2007-07-06 20:42 ` Adrian McMenamin
2007-07-09 8:37 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92a12cdb0707060309x6fe997nc3112d5545d73ef5@mail.gmail.com \
--to=adrianmcmenamin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®