mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Adrian McMenamin" <adrianmcmenamin@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix	behaviour in poor resource conditions
Date: Fri, 06 Jul 2007 11:25:22 +0200	[thread overview]
Message-ID: <s5h3b016fzx.wl%tiwai@suse.de> (raw)
In-Reply-To: <92a12cdb0707051507r7ab1516blb7ea755d89c25efa@mail.gmail.com>

At Thu, 5 Jul 2007 23:07:44 +0100,
Adrian McMenamin wrote:
> @@ -402,17 +396,10 @@
>  static int snd_aicapcm_pcm_trigger(struct snd_pcm_substream
>  				   *substream, int cmd)
>  {
> -	struct snd_card_aica *dreamcastcard;
>  	switch (cmd) {
>  	case SNDRV_PCM_TRIGGER_START:
>  		spu_begin_dma(substream);
>  		break;
> -	case SNDRV_PCM_TRIGGER_STOP:
> -		dreamcastcard = substream->pcm->private_data;
> -		if (dreamcastcard->timer.data)
> -			del_timer(&dreamcastcard->timer);
> -		aica_chn_halt();
> -		break;
>  	default:
>  		return -EINVAL;
>  	}

Is this a correct change?  Then you'd have no control for stopping the
stream.

(BTW, your embedded patch was malformed...)


thanks,

Takashi

  parent reply	other threads:[~2007-07-06  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 22:07 Adrian McMenamin
2007-07-05 22:23 ` Adrian McMenamin
2007-07-06  9:25 ` Takashi Iwai [this message]
2007-07-06  9:46   ` [alsa-devel] " Adrian McMenamin
2007-07-06  9:56     ` Takashi Iwai
2007-07-06 10:09       ` Adrian McMenamin
2007-07-06 20:42         ` Adrian McMenamin
2007-07-09  8:37           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h3b016fzx.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=adrianmcmenamin@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®