From: Laurence Oberman <loberman@redhat.com>
To: Minjie Du <duminjie@vivo.com>,
Markus.Elfring@web.de, Saurav Kashyap <skashyap@marvell.com>,
Javed Hasan <jhasan@marvell.com>,
"supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER"
<GR-QLogic-Storage-Upstream@marvell.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER"
<linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions
Date: Wed, 05 Jul 2023 10:32:25 -0400 [thread overview]
Message-ID: <92beb7aa971b2fb600e4d47158b66bfe660d3c89.camel@redhat.com> (raw)
In-Reply-To: <20230705115236.16571-1-duminjie@vivo.com>
On Wed, 2023-07-05 at 19:52 +0800, Minjie Du wrote:
> Delete a duplicate statement from these function implementations.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> index 776544385..0474fe88a 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> @@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct
> bnx2fc_cmd *seq_clnp_req,
> FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE
> _SHIFT;
> task->rxwr_txrd.const_ctx.init_flags = context_id <<
> FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
> - task->rxwr_txrd.const_ctx.init_flags = context_id <<
> - FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
>
> task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id =
> orig_xid;
>
> @@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd
> *io_req,
> FCOE_TASK_DEV_TYPE_TAPE <<
> FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_S
> HIFT;
> io_req->rec_retry = 0;
> - io_req->rec_retry = 0;
> } else
> task->txwr_rxrd.const_ctx.init_flags |=
> FCOE_TASK_DEV_TYPE_DISK <<
Looks good to me:
Reviewed-by: Laurence Oberman <loberman@redhat.com>
next prev parent reply other threads:[~2023-07-05 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:52 Minjie Du
2023-07-05 14:32 ` Laurence Oberman [this message]
2023-07-06 20:14 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92beb7aa971b2fb600e4d47158b66bfe660d3c89.camel@redhat.com \
--to=loberman@redhat.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=Markus.Elfring@web.de \
--cc=duminjie@vivo.com \
--cc=jejb@linux.ibm.com \
--cc=jhasan@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=opensource.kernel@vivo.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®