* [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions
@ 2023-07-05 11:52 Minjie Du
2023-07-05 14:32 ` Laurence Oberman
2023-07-06 20:14 ` Christophe JAILLET
0 siblings, 2 replies; 3+ messages in thread
From: Minjie Du @ 2023-07-05 11:52 UTC (permalink / raw)
To: Markus.Elfring, Saurav Kashyap, Javed Hasan,
supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER,
James E.J. Bottomley, Martin K. Petersen,
open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER, open list
Cc: opensource.kernel, Minjie Du
Delete a duplicate statement from these function implementations.
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 776544385..0474fe88a 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
@@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct bnx2fc_cmd *seq_clnp_req,
FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE_SHIFT;
task->rxwr_txrd.const_ctx.init_flags = context_id <<
FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
- task->rxwr_txrd.const_ctx.init_flags = context_id <<
- FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id = orig_xid;
@@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd *io_req,
FCOE_TASK_DEV_TYPE_TAPE <<
FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_SHIFT;
io_req->rec_retry = 0;
- io_req->rec_retry = 0;
} else
task->txwr_rxrd.const_ctx.init_flags |=
FCOE_TASK_DEV_TYPE_DISK <<
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions
2023-07-05 11:52 [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions Minjie Du
@ 2023-07-05 14:32 ` Laurence Oberman
2023-07-06 20:14 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Laurence Oberman @ 2023-07-05 14:32 UTC (permalink / raw)
To: Minjie Du, Markus.Elfring, Saurav Kashyap, Javed Hasan,
supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER,
James E.J. Bottomley, Martin K. Petersen,
open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER, open list
Cc: opensource.kernel
On Wed, 2023-07-05 at 19:52 +0800, Minjie Du wrote:
> Delete a duplicate statement from these function implementations.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> index 776544385..0474fe88a 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> @@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct
> bnx2fc_cmd *seq_clnp_req,
> FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE
> _SHIFT;
> task->rxwr_txrd.const_ctx.init_flags = context_id <<
> FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
> - task->rxwr_txrd.const_ctx.init_flags = context_id <<
> - FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
>
> task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id =
> orig_xid;
>
> @@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd
> *io_req,
> FCOE_TASK_DEV_TYPE_TAPE <<
> FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_S
> HIFT;
> io_req->rec_retry = 0;
> - io_req->rec_retry = 0;
> } else
> task->txwr_rxrd.const_ctx.init_flags |=
> FCOE_TASK_DEV_TYPE_DISK <<
Looks good to me:
Reviewed-by: Laurence Oberman <loberman@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions
2023-07-05 11:52 [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions Minjie Du
2023-07-05 14:32 ` Laurence Oberman
@ 2023-07-06 20:14 ` Christophe JAILLET
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2023-07-06 20:14 UTC (permalink / raw)
To: Minjie Du, Markus.Elfring, Saurav Kashyap, Javed Hasan,
supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER,
James E.J. Bottomley, Martin K. Petersen,
open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER, open list,
Laurence Oberman
Cc: opensource.kernel
Le 05/07/2023 à 13:52, Minjie Du a écrit :
> Delete a duplicate statement from these function implementations.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> index 776544385..0474fe88a 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
> @@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct bnx2fc_cmd *seq_clnp_req,
> FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE_SHIFT;
> task->rxwr_txrd.const_ctx.init_flags = context_id <<
> FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
> - task->rxwr_txrd.const_ctx.init_flags = context_id <<
> - FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
>
> task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id = orig_xid;
>
> @@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd *io_req,
> FCOE_TASK_DEV_TYPE_TAPE <<
> FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_SHIFT;
> io_req->rec_retry = 0;
> - io_req->rec_retry = 0;
Hi,
just a blind guess:
io_req->srr_retry = 0;
~~~
?
> } else
> task->txwr_rxrd.const_ctx.init_flags |=
> FCOE_TASK_DEV_TYPE_DISK <<
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-06 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-05 11:52 [PATCH v2] scsi: bnx2fc: Remove a duplicate assignment in two functions Minjie Du
2023-07-05 14:32 ` Laurence Oberman
2023-07-06 20:14 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®