From: Guenter Roeck <linux@roeck-us.net>
To: "Pradhan, Sanman" <sanman.pradhan@hpe.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sanman Pradhan <psanman@juniper.net>
Subject: Re: [PATCH 3/5] hwmon: (pmbus/core) Protect regulator operations with mutex
Date: Wed, 25 Mar 2026 13:02:01 -0700 [thread overview]
Message-ID: <92ccdb7a-e182-4fab-8141-14fb34386bc1@roeck-us.net> (raw)
In-Reply-To: <20260325190502.109001-1-sanman.pradhan@hpe.com>
Hi,
On 3/25/26 12:05, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@juniper.net>
>
> Reviewed the series.
>
> Very minor hardening thought: the notifier worker is
> initialized after the devm_regulator_register() loop.
>
> The current probe ordering makes that fine, so I don't
> think this is a bug, but would it be cleaner to initialize
> the notifier state a bit earlier just to keep that
> setup self-contained?
>
The interrupt handler is installed after registering the regulator,
so I don't think that is a problem since the regulator notifier
is called from the interrupt handler.
> Don't see any blocking issues in the rest of the series.
>
Thanks a lot for the review and feedback. Surprisingly, Sashiko did not
find anything either:
https://sashiko.dev/#/patchset/20260325181631.17259-1-linux%40roeck-us.net
If you don't mind, please send me a formal Reviewed-by: tag for the series
or for individual patches.
Thanks,
Guenter
prev parent reply other threads:[~2026-03-25 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260325181631.17259-4-linux@roeck-us.net>
2026-03-25 19:05 ` Pradhan, Sanman
2026-03-25 20:02 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92ccdb7a-e182-4fab-8141-14fb34386bc1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psanman@juniper.net \
--cc=sanman.pradhan@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®