Re: [PATCH v6 4/6] clk: samsung: add Exynos ACPM clock driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/10/2025 14:46, Tudor Ambarus wrote:
> Add the Exynos ACPM clock driver. It provides support for clocks that
> are controlled by firmware that implements the ACPM interface.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
> Tested-by: Peter Griffin <peter.griffin@linaro.org> # on gs101-oriole
> ---
>  drivers/clk/samsung/Kconfig    |  10 +++
>  drivers/clk/samsung/Makefile   |   1 +
>  drivers/clk/samsung/clk-acpm.c | 185 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 196 insertions(+)
> 
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> index 76a494e95027af26272e30876a87ac293bd56dfa..70a8b82a0136b4d0213d8ff95e029c52436e5c7f 100644
> --- a/drivers/clk/samsung/Kconfig
> +++ b/drivers/clk/samsung/Kconfig
> @@ -95,6 +95,16 @@ config EXYNOS_CLKOUT
>  	  status of the certains clocks from SoC, but it could also be tied to
>  	  other devices as an input clock.
>  
> +config EXYNOS_ACPM_CLK
> +	tristate "Clock driver controlled via ACPM interface"
> +	depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL)


I merged the patches but I don't get why we are not enabling it by
default, just like every other clock driver. What is so special here?

> +	help
> +	  This driver provides support for clocks that are controlled by
> +	  firmware that implements the ACPM interface.
> +
> +	  This driver uses the ACPM interface to interact with the firmware
> +	  providing all the clock controlls.
> +
>  config TESLA_FSD_COMMON_CLK
>  	bool "Tesla FSD clock controller support" if COMPILE_TEST
>  	depends on COMMON_CLK_SAMSUNG
Best regards,
Krzysztof