Re: [PATCH v6 4/6] clk: samsung: add Exynos ACPM clock driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/10/2025 11:19, Tudor Ambarus wrote:
> 
> 
> On 10/20/25 9:22 AM, Krzysztof Kozlowski wrote:
>> On 20/10/2025 09:45, Tudor Ambarus wrote:
>>>
>>>
>>> On 10/20/25 7:54 AM, Krzysztof Kozlowski wrote:
>>>>> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
>>>>> index 76a494e95027af26272e30876a87ac293bd56dfa..70a8b82a0136b4d0213d8ff95e029c52436e5c7f 100644
>>>>> --- a/drivers/clk/samsung/Kconfig
>>>>> +++ b/drivers/clk/samsung/Kconfig
>>>>> @@ -95,6 +95,16 @@ config EXYNOS_CLKOUT
>>>>>  	  status of the certains clocks from SoC, but it could also be tied to
>>>>>  	  other devices as an input clock.
>>>>>  
>>>>> +config EXYNOS_ACPM_CLK
>>>>> +	tristate "Clock driver controlled via ACPM interface"
>>>>> +	depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL)
>>>>
>>>> I merged the patches but I don't get why we are not enabling it by
>>>> default, just like every other clock driver. What is so special here?
>>>
>>> Thanks! Are you referring to the depends on line? I needed it otherwise
>>> on randconfigs where COMPILE_TEST=y and EXYNOS_ACPM_PROTOCOL=n I get:
>>
>>
>> No. I am referring to missing default and defconfig patch.
>>
> 
> default m or y would force compilation of EXYNOS_ACPM_CLK and
> EXYNOS_ACPM_PROTOCOL for all ARCH_EXYNOS, even on Exynos platforms that
> don't use ACPM. Since ACPM is not universally required by the Exynos
> architecture, I thought to make it opt-in (default n).


Just like every clock driver. So again - how is it different?

> 
> Setting it as a module in arm64 defconfig makes it available on
> compatible platforms.
> 
> Similar clock drivers do the same: CLK_RASPBERRYPI.
> COMMON_CLK_SCPI, COMMON_CLK_SCMI - no defaults and set them as builtin
> in the arm64 defconfig.


I am speaking about Samsung drivers.


Best regards,
Krzysztof