From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: WangYuli <wangyuli@uniontech.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Arnd Bergmann" <arnd@kernel.org>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
pnewman@connecttech.com, "Sunil V L" <sunilvl@ventanamicro.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
zhanjun@uniontech.com, guanwentao@uniontech.com,
"Zhuozhen He" <hezhuozhen@uniontech.com>,
"Guowei Chen" <chenguowei@uniontech.com>
Subject: Re: [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver
Date: Mon, 13 Jan 2025 14:12:01 +0100 [thread overview]
Message-ID: <92fa2e1d-2dbb-4d28-a7c5-c0f629f9b05a@app.fastmail.com> (raw)
In-Reply-To: <Z4UE995i2OYv-h5E@smile.fi.intel.com>
On Mon, Jan 13, 2025, at 13:20, Andy Shevchenko wrote:
> On Mon, Jan 13, 2025 at 11:36:08AM +0100, Arnd Bergmann wrote:
>> On Mon, Jan 13, 2025, at 10:59, Andy Shevchenko wrote:
>> > On Thu, Jan 09, 2025 at 01:40:14PM +0100, Arnd Bergmann wrote:
>> >> On Thu, Jan 9, 2025, at 13:08, WangYuli wrote:
>> >>
>> >> Can you explain why this isn't done as part of
>> >> drivers/tty/serial/8250/8250_pnp.c?
>> >
>> > I assume you meant 8250_platform.c. PNP is for devices went through legacy PNP
>> > enumeration, most likely having IOPORT instead of IOMEM.
>>
>> No, I meant the 8250_pnp.c file.
>
> I am puzzled then. How should it work? PNP ID != ACPI HID that's provided in
> this patch commit message. On top of that, PNP driver uses _legacy_ PMP bus
> and infrastructure.
I guess I don't understand enough about ACPI then, I always
assumed these were the same identifiers. I do see that
CONFIG_ACPI force-enables CONFIG_PNP, and I see the examples in
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/ evice_Configuration.html
refer to _HID values in the form of "PNP####".
Arnd
next prev parent reply other threads:[~2025-01-13 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 12:08 WangYuli
2025-01-09 12:40 ` Arnd Bergmann
2025-01-13 9:59 ` Andy Shevchenko
2025-01-13 10:36 ` Arnd Bergmann
2025-01-13 12:20 ` Andy Shevchenko
2025-01-13 13:12 ` Arnd Bergmann [this message]
2025-01-13 15:31 ` Andy Shevchenko
2025-01-11 1:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fa2e1d-2dbb-4d28-a7c5-c0f629f9b05a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=chenguowei@uniontech.com \
--cc=gregkh@linuxfoundation.org \
--cc=guanwentao@uniontech.com \
--cc=hezhuozhen@uniontech.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pnewman@connecttech.com \
--cc=schnelle@linux.ibm.com \
--cc=sunilvl@ventanamicro.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®