From: Paul Durrant <Paul.Durrant@citrix.com>
To: "'Boris Ostrovsky'" <boris.ostrovsky@oracle.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Juergen Gross <jgross@suse.com>
Subject: RE: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP
Date: Tue, 14 Feb 2017 09:20:42 +0000 [thread overview]
Message-ID: <9328bb49eb634b0994e41f19733a373e@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <0ae0162c-4317-7dbf-fdce-354f71583d0a@oracle.com>
My previous reply got bounced because my tablet insisted on using HTML...
> -----Original Message-----
>
> These need to be static. (I can fix it when committing.)
Ok, thanks.
>
> And I am still not sure about using XEN_PAGE_SIZE. There is no
> dependency in the hypervisor on buffers being page-sized, is there? If
> not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a
> reasonable value.
>
> How about just setting it to 4096?
>
I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that.
Paul
PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4?
>
> -boris
next prev parent reply other threads:[~2017-02-14 9:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 17:03 [PATCH v3 0/3] xen/privcmd: support for dm_op and restriction Paul Durrant
2017-02-13 17:03 ` [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs Paul Durrant
2017-02-13 18:52 ` Boris Ostrovsky
2017-02-13 17:03 ` [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant
2017-02-13 19:11 ` Boris Ostrovsky
2017-02-14 9:20 ` Paul Durrant [this message]
2017-02-14 14:11 ` Boris Ostrovsky
2017-02-14 17:25 ` Boris Ostrovsky
2017-02-14 18:38 ` Stefano Stabellini
2017-02-15 9:14 ` Paul Durrant
2017-02-15 14:47 ` Boris Ostrovsky
2017-02-13 17:03 ` [PATCH v3 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT Paul Durrant
2017-02-13 19:20 ` Boris Ostrovsky
2017-02-15 14:49 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9328bb49eb634b0994e41f19733a373e@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®